Fix --enable-stats-table crash on Release builds.

Fix --enable-stats-table crash on Release builds.

Currently, using the --enable-stats-table flag when running a Release build of chromium causes a segfault on startup.

I traced the issue back to a dangling reference to a local variable that had gone out of scope, so dynamically allocating the variable and storing it as a class member fixes the issue.

BUG=137243
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164848

[hartmanng, 2012-10-26 15:49:18]

This appears to fix the issue for Release builds on linux and windows (VS2010).
Please take a look.

[cpu_(ooo_6.6-7.5), 2012-10-26 22:34:04]

not sure what this does, can you improve your CL description and maybe reference
a bug?

[Ian Vollick, 2012-10-26 23:35:01]

On 2012/10/26 22:34:04, cpu wrote:
> not sure what this does, can you improve your CL description and maybe
reference
> a bug?

It used to be the case that we were storing a reference to a local variable.
This caused a crash when we tried to use it later after the local had gone out
of scope. This change just makes sure that the stats counter timer has the same
lifetime as the stats scope that keeps a reference to it.

[hartmanng, 2012-10-26 23:58:36]

On 2012/10/26 23:35:01, vollick wrote:
> On 2012/10/26 22:34:04, cpu wrote:
> > not sure what this does, can you improve your CL description and maybe
> reference
> > a bug?
> 
> It used to be the case that we were storing a reference to a local variable.
> This caused a crash when we tried to use it later after the local had gone out
> of scope. This change just makes sure that the stats counter timer has the
same
> lifetime as the stats scope that keeps a reference to it.

Thanks vollick, I also paraphrased this for the CL description.

cpu: note there's a bug filed for this here
http://code.google.com/p/chromium/issues/detail?id=137243 . Let me know if it's
still unclear.

[cpu_(ooo_6.6-7.5), 2012-10-29 23:31:00]

lgtm

[commit-bot: I haz the power, 2012-10-30 01:22:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11260033/1

[commit-bot: I haz the power, 2012-10-30 04:57:05]

Change committed as 164848