* Invoke Google Update to do the exe rename.

chrome/browser/first_run.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <atlbase.h>
+#include <atlcom.h>
 #include <windows.h>
 #include <shlobj.h>
 
 #include <sstream>
 
 #include "chrome/browser/first_run.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/object_watcher.h"
@@ skipping 16 matching lines @@
 #include "chrome/common/pref_service.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/master_preferences.h"
 #include "chrome/installer/util/shell_util.h"
 #include "chrome/installer/util/util_constants.h"
 #include "chrome/views/accelerator_handler.h"
 #include "chrome/views/window.h"
 
+#include "google_update_idl.h"
+
 namespace {
 
 // The kSentinelFile file absence will tell us it is a first run.
 const wchar_t kSentinelFile[] = L"First Run";
 
 // Gives the full path to the sentinel file. The file might not exist.
 bool GetFirstRunSentinelFilePath(std::wstring* path) {
   std::wstring first_run_sentinel;
   if (!PathService::Get(base::DIR_EXE, &first_run_sentinel))
     return false;
@@ skipping 22 matching lines @@
       ProfileManager::GetDefaultProfileDir(user_data_dir);
   if (create_profile_dir) {
     if (!file_util::PathExists(default_pref_dir)) {
       if (!file_util::CreateDirectory(default_pref_dir))
         return std::wstring();
     }
   }
   return ProfileManager::GetDefaultProfilePath(default_pref_dir);
 }
 
+bool InvokeGoogleUpdateForRename() {
+  CComPtr<IProcessLauncher> ipl;
+  if (!FAILED(ipl.CoCreateInstance(__uuidof(ProcessLauncherClass)))) {
+    ULONG_PTR phandle = NULL;
+    DWORD id = GetCurrentProcessId();
+    if (!FAILED(ipl->LaunchCmdElevated(google_update::kChromeGuid,
+                                       google_update::kRegRenameCmdField,
+                                       id, &phandle))) {
+      HANDLE handle = HANDLE(phandle);
+      ::GetExitCodeProcess(handle, exit_code);
+      ::CloseHandle(handle);
+      if (exit_code == installer_util::RENAME_SUCCESSFUL)
+        return true;
+    }
+  }
+  return false;

[cpu_(ooo_6.6-7.5), 2008/11/20 02:43:38]

So this rename does also the opv key work?

+}
+
 }  // namespace
 
 bool FirstRun::IsChromeFirstRun() {
   std::wstring first_run_sentinel;
   if (!GetFirstRunSentinelFilePath(&first_run_sentinel))
     return false;
   if (file_util::PathExists(first_run_sentinel))
     return false;
   return true;
 }
@@ skipping 120 matching lines @@
   return base::LaunchApp(command_line.command_line_string(),
                          false, false, NULL);
 }
 
 bool Upgrade::SwapNewChromeExeIfPresent() {
   std::wstring new_chrome_exe;
   if (!GetNewerChromeFile(&new_chrome_exe))
     return false;
   if (!file_util::PathExists(new_chrome_exe))
     return false;
-  std::wstring old_chrome_exe;
-  if (!PathService::Get(base::FILE_EXE, &old_chrome_exe))
+  std::wstring curr_chrome_exe;
+  if (!PathService::Get(base::FILE_EXE, &curr_chrome_exe))
     return false;
+
+  // First try to rename exe by launching rename command ourselves.
+  bool user_install = InstallUtil::IsPerUserInstall(curr_chrome_exe.c_str());
+  HKEY reg_root = user_install ? HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE;
+  BrowserDistribution *dist = BrowserDistribution::GetDistribution();
   RegKey key;
-  HKEY reg_root = InstallUtil::IsPerUserInstall(old_chrome_exe.c_str()) ?
-      HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE;
-  BrowserDistribution *dist = BrowserDistribution::GetDistribution();
   std::wstring rename_cmd;
   if (key.Open(reg_root, dist->GetVersionKey().c_str(), KEY_READ) &&
       key.ReadValue(google_update::kRegRenameCmdField, &rename_cmd)) {
     base::ProcessHandle handle;
     if (base::LaunchApp(rename_cmd, true, true, &handle)) {
       DWORD exit_code;
       ::GetExitCodeProcess(handle, &exit_code);
       ::CloseHandle(handle);
       if (exit_code == installer_util::RENAME_SUCCESSFUL)
         return true;
     }
   }
+
+  // Rename didn't work so try to rename by calling Google Update
+  if (InvokeGoogleUpdateForRename(&exit_code))
+    return true;
+
+  // Rename still didn't work so just try to rename exe ourselves (for
+  // backward compatibility, can be deleted once the new process works).
   std::wstring backup_exe;
   if (!GetBackupChromeFile(&backup_exe))
     return false;
-  if (::ReplaceFileW(old_chrome_exe.c_str(), new_chrome_exe.c_str(),
+  if (::ReplaceFileW(curr_chrome_exe.c_str(), new_chrome_exe.c_str(),
                      backup_exe.c_str(), REPLACEFILE_IGNORE_MERGE_ERRORS,
                      NULL, NULL)) {
     return true;
   }
   return false;
 }
 
 void OpenFirstRunDialog(Profile* profile) {
   views::Window::CreateChromeWindow(NULL, gfx::Rect(),
                                     new FirstRunView(profile))->Show();
@@ skipping 237 matching lines @@
 bool FirstRun::SetShowWelcomePagePref() {
   PrefService* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   if (!local_state->IsPrefRegistered(prefs::kShouldShowWelcomePage)) {
     local_state->RegisterBooleanPref(prefs::kShouldShowWelcomePage, false);
     local_state->SetBoolean(prefs::kShouldShowWelcomePage, true);
   }
   return true;
 }