Issue 1125005: Bump GYP dep to get fixes for escaping/quoting in 'defines'....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1125005: Bump GYP dep to get fixes for escaping/quoting in 'defines'.... (Closed)

Created:
10 years, 9 months ago by Tristan Schmelcher 2

Modified:
9 years, 6 months ago

Reviewers:
piman

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Bump GYP dep to get fixes for escaping/quoting in 'defines'. TEST=built on Linux BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42180

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM. I assume you looked at the changes and nothing looks arbitrarily scary.

10 years, 9 months ago (2010-03-20 00:48:02 UTC) #2

Tristan Schmelcher 2

I wrote the changes. :) On 2010/03/20 00:48:02, piman wrote: > LGTM. I assume you ...

10 years, 9 months ago (2010-03-20 00:52:08 UTC) #3

Tristan Schmelcher 2

10 years, 9 months ago (2010-03-20 01:04:03 UTC) #4

Ah. No, I did not look at those CLs. The trybots pass so I'm happy. I'll take a
look at the list before submitting.

On 2010/03/20 00:52:08, tschmelcher wrote:
> I wrote the changes. :)
> 
> On 2010/03/20 00:48:02, piman wrote:
> > LGTM. I assume you looked at the changes and nothing looks arbitrarily
scary.

Expand Messages | Collapse Messages