Remove cf_html from webdropdata.h. This is windows

Remove cf_html from webdropdata.h.  This is windows
specific code so we should handle it before we get
to webkit.

CF_HTML needs the source URL to resolve relative URLs
so I added that to the format and plumb it through
from webcore.

I also did some small refactoring so we only have one
implementation of converting to/from CF_HTML and regular
markup.  We can tweak these converters (and add unit tests)
in follow up changes.

[Evan Stade, 2008-11-18 23:58:15]

base/ changes look good to me

http://codereview.chromium.org/11247/diff/201/35
File base/clipboard_util.cc (right):

http://codereview.chromium.org/11247/diff/201/35#newcode473
Line 473: // -->".
nit: can't this fit on the line above?

[sky, 2008-11-19 00:05:37]

http://codereview.chromium.org/11247/diff/201/40
File chrome/common/os_exchange_data.cc (right):

http://codereview.chromium.org/11247/diff/201/40#newcode45
Line 45: source->ptd =
I see this code is just getting moved around, but how come this effects source?
Shouldn't this only effect clone?

http://codereview.chromium.org/11247/diff/201/40#newcode345
Line 345: std::string url = base_url.is_valid() ? base_url.spec() : "";
nit: "" -> std::string()

http://codereview.chromium.org/11247/diff/201/40#newcode415
Line 415: *base_url = GURL(url);
Should this always set base_url if success?

http://codereview.chromium.org/11247/diff/201/46
File webkit/glue/webdropdata.h (right):

http://codereview.chromium.org/11247/diff/201/46#newcode31
Line 31: GURL html_base_url;
comment?

[tony, 2008-11-19 00:31:06]

I think I addressed all the comments from Evan and Scott.  I moved the
CloneFormatEtc function back.  I think it changes ptd on both the source and the
object, although I admit, I don't really understand the code.

Take another look?


On 2008/11/19 00:05:37, sky wrote:
> http://codereview.chromium.org/11247/diff/201/40
> File chrome/common/os_exchange_data.cc (right):
> 
> http://codereview.chromium.org/11247/diff/201/40#newcode45
> Line 45: source->ptd =
> I see this code is just getting moved around, but how come this effects
source?
> Shouldn't this only effect clone?
> 
> http://codereview.chromium.org/11247/diff/201/40#newcode345
> Line 345: std::string url = base_url.is_valid() ? base_url.spec() : "";
> nit: "" -> std::string()
> 
> http://codereview.chromium.org/11247/diff/201/40#newcode415
> Line 415: *base_url = GURL(url);
> Should this always set base_url if success?
> 
> http://codereview.chromium.org/11247/diff/201/46
> File webkit/glue/webdropdata.h (right):
> 
> http://codereview.chromium.org/11247/diff/201/46#newcode31
> Line 31: GURL html_base_url;
> comment?

[sky, 2008-11-19 00:41:46]

LGTM