Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5267)

Unified Diff: chrome/common/pref_store.h

Issue 11243002: Move the bits of Prefs where production code has only trivially easy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments, fix gypi problem Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/persistent_pref_store.h ('k') | chrome/common/pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/pref_store.h
diff --git a/chrome/common/pref_store.h b/chrome/common/pref_store.h
deleted file mode 100644
index c0a23cf2beb19469aaabde76ff07b89e08879b96..0000000000000000000000000000000000000000
--- a/chrome/common/pref_store.h
+++ /dev/null
@@ -1,72 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_COMMON_PREF_STORE_H_
-#define CHROME_COMMON_PREF_STORE_H_
-
-#include <string>
-
-#include "base/basictypes.h"
-#include "base/memory/ref_counted.h"
-
-namespace base {
-class Value;
-}
-
-// This is an abstract interface for reading and writing from/to a persistent
-// preference store, used by PrefService. An implementation using a JSON file
-// can be found in JsonPrefStore, while an implementation without any backing
-// store for testing can be found in TestingPrefStore. Furthermore, there is
-// CommandLinePrefStore, which bridges command line options to preferences and
-// ConfigurationPolicyPrefStore, which is used for hooking up configuration
-// policy with the preference subsystem.
-class PrefStore : public base::RefCounted<PrefStore> {
- public:
- // Observer interface for monitoring PrefStore.
- class Observer {
- public:
- // Called when the value for the given |key| in the store changes.
- virtual void OnPrefValueChanged(const std::string& key) = 0;
- // Notification about the PrefStore being fully initialized.
- virtual void OnInitializationCompleted(bool succeeded) = 0;
-
- protected:
- virtual ~Observer() {}
- };
-
- // Return values for GetValue().
- enum ReadResult {
- // Value found and returned.
- READ_OK,
- // No value present, but skip other pref stores and use default.
- READ_USE_DEFAULT,
- // No value present.
- READ_NO_VALUE,
- };
-
- PrefStore() {}
-
- // Add and remove observers.
- virtual void AddObserver(Observer* observer) {}
- virtual void RemoveObserver(Observer* observer) {}
- virtual size_t NumberOfObservers() const;
-
- // Whether the store has completed all asynchronous initialization.
- virtual bool IsInitializationComplete() const;
-
- // Get the value for a given preference |key| and stores it in |*result|.
- // |*result| is only modified if the return value is READ_OK and if |result|
- // is not NULL. Ownership of the |*result| value remains with the PrefStore.
- virtual ReadResult GetValue(const std::string& key,
- const base::Value** result) const = 0;
-
- protected:
- friend class base::RefCounted<PrefStore>;
- virtual ~PrefStore() {}
-
- private:
- DISALLOW_COPY_AND_ASSIGN(PrefStore);
-};
-
-#endif // CHROME_COMMON_PREF_STORE_H_
« no previous file with comments | « chrome/common/persistent_pref_store.h ('k') | chrome/common/pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698