Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/prefs/value_map_pref_store.h

Issue 11243002: Move the bits of Prefs where production code has only trivially easy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments, fix gypi problem Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/testing_pref_store.cc ('k') | chrome/browser/prefs/value_map_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/value_map_pref_store.h
diff --git a/chrome/browser/prefs/value_map_pref_store.h b/chrome/browser/prefs/value_map_pref_store.h
deleted file mode 100644
index af231b91c5bae9dafecc9bdb83cc08f0ee56af25..0000000000000000000000000000000000000000
--- a/chrome/browser/prefs/value_map_pref_store.h
+++ /dev/null
@@ -1,59 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_
-#define CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_
-
-#include <map>
-#include <string>
-
-#include "base/basictypes.h"
-#include "base/observer_list.h"
-#include "chrome/browser/prefs/pref_value_map.h"
-#include "chrome/common/pref_store.h"
-
-// A basic PrefStore implementation that uses a simple name-value map for
-// storing the preference values.
-class ValueMapPrefStore : public PrefStore {
- public:
- typedef std::map<std::string, base::Value*>::iterator iterator;
- typedef std::map<std::string, base::Value*>::const_iterator const_iterator;
-
- ValueMapPrefStore();
-
- // PrefStore overrides:
- virtual ReadResult GetValue(const std::string& key,
- const base::Value** value) const OVERRIDE;
- virtual void AddObserver(PrefStore::Observer* observer) OVERRIDE;
- virtual void RemoveObserver(PrefStore::Observer* observer) OVERRIDE;
- virtual size_t NumberOfObservers() const OVERRIDE;
-
- iterator begin();
- iterator end();
- const_iterator begin() const;
- const_iterator end() const;
-
- protected:
- virtual ~ValueMapPrefStore();
-
- // Store a |value| for |key| in the store. Also generates an notification if
- // the value changed. Assumes ownership of |value|, which must be non-NULL.
- void SetValue(const std::string& key, base::Value* value);
-
- // Remove the value for |key| from the store. Sends a notification if there
- // was a value to be removed.
- void RemoveValue(const std::string& key);
-
- // Notify observers about the initialization completed event.
- void NotifyInitializationCompleted();
-
- private:
- PrefValueMap prefs_;
-
- ObserverList<PrefStore::Observer, true> observers_;
-
- DISALLOW_COPY_AND_ASSIGN(ValueMapPrefStore);
-};
-
-#endif // CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_
« no previous file with comments | « chrome/browser/prefs/testing_pref_store.cc ('k') | chrome/browser/prefs/value_map_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698