chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm - Issue 11243002: Move the bits of Prefs where production code has only trivially easy

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

Issue 11243002: Move the bits of Prefs where production code has only trivially easy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, fix gypi problem Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/gesture_prefs_observer_factory_aura.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h"	5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h"

6	6

	7 #include "base/prefs/public/pref_change_registrar.h"

7 #include "base/sys_string_conversions.h"	8 #include "base/sys_string_conversions.h"

8 #include "chrome/browser/api/prefs/pref_change_registrar.h"

9 #include "chrome/browser/extensions/extension_action.h"	9 #include "chrome/browser/extensions/extension_action.h"

10 #include "chrome/browser/extensions/extension_action_manager.h"	10 #include "chrome/browser/extensions/extension_action_manager.h"

11 #include "chrome/browser/extensions/extension_service.h"	11 #include "chrome/browser/extensions/extension_service.h"

12 #include "chrome/browser/extensions/extension_tab_util.h"	12 #include "chrome/browser/extensions/extension_tab_util.h"

13 #include "chrome/browser/extensions/extension_uninstall_dialog.h"	13 #include "chrome/browser/extensions/extension_uninstall_dialog.h"

14 #include "chrome/browser/prefs/pref_service.h"	14 #include "chrome/browser/prefs/pref_service.h"

15 #include "chrome/browser/profiles/profile.h"	15 #include "chrome/browser/profiles/profile.h"

16 #include "chrome/browser/ui/browser.h"	16 #include "chrome/browser/ui/browser.h"

17 #include "chrome/browser/ui/browser_finder.h"	17 #include "chrome/browser/ui/browser_finder.h"

18 #include "chrome/browser/ui/browser_tabstrip.h"	18 #include "chrome/browser/ui/browser_tabstrip.h"

(...skipping 178 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
197	197

198 - (BOOL)validateMenuItem:(NSMenuItem*)menuItem {	198 - (BOOL)validateMenuItem:(NSMenuItem*)menuItem {

199 if ([menuItem tag] == kExtensionContextOptions) {	199 if ([menuItem tag] == kExtensionContextOptions) {

200 // Disable 'Options' if there are no options to set.	200 // Disable 'Options' if there are no options to set.

201 return extension_->options_url().spec().length() > 0;	201 return extension_->options_url().spec().length() > 0;

202 }	202 }

203 return YES;	203 return YES;

204 }	204 }

205	205

206 @end	206 @end

OLD	NEW