chrome/browser/prefs/scoped_user_pref_update_unittest.cc - Issue 11243002: Move the bits of Prefs where production code has only trivially easy

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/scoped_user_pref_update_unittest.cc

Issue 11243002: Move the bits of Prefs where production code has only trivially easy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, fix gypi problem Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/prefs/scoped_user_pref_update.cc ('k') | chrome/browser/prefs/testing_pref_store.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/api/prefs/pref_change_registrar.h"	5 #include "base/prefs/public/pref_change_registrar.h"

6 #include "chrome/browser/prefs/pref_observer_mock.h"	6 #include "chrome/browser/prefs/pref_observer_mock.h"

7 #include "chrome/browser/prefs/scoped_user_pref_update.h"	7 #include "chrome/browser/prefs/scoped_user_pref_update.h"

8 #include "chrome/test/base/testing_pref_service.h"	8 #include "chrome/test/base/testing_pref_service.h"

9 #include "testing/gmock/include/gmock/gmock.h"	9 #include "testing/gmock/include/gmock/gmock.h"

10 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

11	11

12 using testing::_;	12 using testing::_;

13 using testing::Mock;	13 using testing::Mock;

14	14

15 class ScopedUserPrefUpdateTest : public testing::Test {	15 class ScopedUserPrefUpdateTest : public testing::Test {

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 TEST_F(ScopedUserPrefUpdateTest, NeverTouchAnything) {	70 TEST_F(ScopedUserPrefUpdateTest, NeverTouchAnything) {

71 const DictionaryValue* old_value = prefs_.GetDictionary(kPref);	71 const DictionaryValue* old_value = prefs_.GetDictionary(kPref);

72 EXPECT_CALL(observer_, Observe(_, _, _)).Times(0);	72 EXPECT_CALL(observer_, Observe(_, _, _)).Times(0);

73 {	73 {

74 DictionaryPrefUpdate update(&prefs_, kPref);	74 DictionaryPrefUpdate update(&prefs_, kPref);

75 }	75 }

76 const DictionaryValue* new_value = prefs_.GetDictionary(kPref);	76 const DictionaryValue* new_value = prefs_.GetDictionary(kPref);

77 EXPECT_EQ(old_value, new_value);	77 EXPECT_EQ(old_value, new_value);

78 Mock::VerifyAndClearExpectations(&observer_);	78 Mock::VerifyAndClearExpectations(&observer_);

79 }	79 }

OLD	NEW