Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/browser/prefs/pref_value_store.cc

Issue 11243002: Move the bits of Prefs where production code has only trivially easy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments, fix gypi problem Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/pref_value_store.h" 5 #include "chrome/browser/prefs/pref_value_store.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_notifier.h"
8 #include "chrome/browser/prefs/pref_model_associator.h" 9 #include "chrome/browser/prefs/pref_model_associator.h"
9 #include "chrome/browser/prefs/pref_notifier.h"
10 10
11 PrefValueStore::PrefStoreKeeper::PrefStoreKeeper() 11 PrefValueStore::PrefStoreKeeper::PrefStoreKeeper()
12 : pref_value_store_(NULL), 12 : pref_value_store_(NULL),
13 type_(PrefValueStore::INVALID_STORE) { 13 type_(PrefValueStore::INVALID_STORE) {
14 } 14 }
15 15
16 PrefValueStore::PrefStoreKeeper::~PrefStoreKeeper() { 16 PrefValueStore::PrefStoreKeeper::~PrefStoreKeeper() {
17 if (pref_store_.get()) { 17 if (pref_store_.get()) {
18 pref_store_->RemoveObserver(this); 18 pref_store_->RemoveObserver(this);
19 pref_store_ = NULL; 19 pref_store_ = NULL;
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 if (initialization_failed_) 278 if (initialization_failed_)
279 return; 279 return;
280 for (size_t i = 0; i <= PREF_STORE_TYPE_MAX; ++i) { 280 for (size_t i = 0; i <= PREF_STORE_TYPE_MAX; ++i) {
281 scoped_refptr<PrefStore> store = 281 scoped_refptr<PrefStore> store =
282 GetPrefStore(static_cast<PrefStoreType>(i)); 282 GetPrefStore(static_cast<PrefStoreType>(i));
283 if (store && !store->IsInitializationComplete()) 283 if (store && !store->IsInitializationComplete())
284 return; 284 return;
285 } 285 }
286 pref_notifier_->OnInitializationCompleted(true); 286 pref_notifier_->OnInitializationCompleted(true);
287 } 287 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/pref_value_store.h ('k') | chrome/browser/prefs/pref_value_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698