Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chrome/browser/bookmarks/bookmark_extension_api.cc

Issue 11243002: Move the bits of Prefs where production code has only trivially easy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments, fix gypi problem Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_extension_api.h" 5 #include "chrome/browser/bookmarks/bookmark_extension_api.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/file_path.h" 8 #include "base/file_path.h"
9 #include "base/i18n/file_util_icu.h" 9 #include "base/i18n/file_util_icu.h"
10 #include "base/i18n/time_formatting.h" 10 #include "base/i18n/time_formatting.h"
11 #include "base/json/json_writer.h" 11 #include "base/json/json_writer.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/path_service.h" 13 #include "base/path_service.h"
14 #include "base/prefs/public/pref_service_base.h"
14 #include "base/sha1.h" 15 #include "base/sha1.h"
15 #include "base/stl_util.h" 16 #include "base/stl_util.h"
16 #include "base/string16.h" 17 #include "base/string16.h"
17 #include "base/string_number_conversions.h" 18 #include "base/string_number_conversions.h"
18 #include "base/string_util.h" 19 #include "base/string_util.h"
19 #include "base/time.h" 20 #include "base/time.h"
20 #include "base/utf_string_conversions.h" 21 #include "base/utf_string_conversions.h"
21 #include "chrome/browser/api/prefs/pref_service_base.h"
22 #include "chrome/browser/bookmarks/bookmark_codec.h" 22 #include "chrome/browser/bookmarks/bookmark_codec.h"
23 #include "chrome/browser/bookmarks/bookmark_extension_api_constants.h" 23 #include "chrome/browser/bookmarks/bookmark_extension_api_constants.h"
24 #include "chrome/browser/bookmarks/bookmark_extension_helpers.h" 24 #include "chrome/browser/bookmarks/bookmark_extension_helpers.h"
25 #include "chrome/browser/bookmarks/bookmark_html_writer.h" 25 #include "chrome/browser/bookmarks/bookmark_html_writer.h"
26 #include "chrome/browser/bookmarks/bookmark_model.h" 26 #include "chrome/browser/bookmarks/bookmark_model.h"
27 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 27 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
28 #include "chrome/browser/bookmarks/bookmark_utils.h" 28 #include "chrome/browser/bookmarks/bookmark_utils.h"
29 #include "chrome/browser/extensions/event_router.h" 29 #include "chrome/browser/extensions/event_router.h"
30 #include "chrome/browser/extensions/extension_function_dispatcher.h" 30 #include "chrome/browser/extensions/extension_function_dispatcher.h"
31 #include "chrome/browser/extensions/extensions_quota_service.h" 31 #include "chrome/browser/extensions/extensions_quota_service.h"
(...skipping 926 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 int index, 958 int index,
959 void* params) { 959 void* params) {
960 #if !defined(OS_ANDROID) 960 #if !defined(OS_ANDROID)
961 // Android does not have support for the standard exporter. 961 // Android does not have support for the standard exporter.
962 // TODO(jgreenwald): remove ifdef once extensions are no longer built on 962 // TODO(jgreenwald): remove ifdef once extensions are no longer built on
963 // Android. 963 // Android.
964 bookmark_html_writer::WriteBookmarks(profile(), path, NULL); 964 bookmark_html_writer::WriteBookmarks(profile(), path, NULL);
965 #endif 965 #endif
966 Release(); // Balanced in BookmarksIOFunction::SelectFile() 966 Release(); // Balanced in BookmarksIOFunction::SelectFile()
967 } 967 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698