chrome/browser/browsing_data/browsing_data_remover_browsertest.cc - Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Final touches. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_remover.cc ('K') | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | chrome/browser/net/http_server_properties_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

index 39b2a200386afc8613a09d688f2d96101c3c5e8c..0568a57160296a86742bbea4e001fbdacea287ca 100644

--- a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

@@ -112,3 +112,8 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverBrowserTest, Database) {

RunScriptAndCheckResult(L"insertRecord('text2')", "done");

RunScriptAndCheckResult(L"getRecords()", "text2");

}

+// Profile::ClearNetworkingHistorySince should be exercised here too see whether

+// the call gets delegated through ProfileIO[Impl]Data properly, which is hard

+// to write unit-tests for. Currently this is done by both of the above tests.

+// Add standalone test if this changes.