Webview tag creation should be using storage partitions.

content/public/browser/content_browser_client.h

Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 189339e8e5e038a0a5ecd4ea0588a9ec94320a13..8de22d84b3710047ff5542ca9ad8b0b3a36804f5 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -263,23 +263,7 @@ class CONTENT_EXPORT ContentBrowserClient {
   virtual net::URLRequestContext* OverrideRequestContextForURL(
       const GURL& url, ResourceContext* context);
 
-  // Allow the embedder to specify storage parititon id associated with a child
-  // process.
-  //
-  // Child processes that have different storage partition identifiers will
-  // behave as if they belong to different web browsers and not be able to
-  // access each other's cookies, local storage, etc.  IDs must only fit the
-  // pattern [a-z0-9]* (lowercase letters or digits).
-  //
-  // Returns the empty string for the regular storage partition.
-  virtual std::string GetStoragePartitionIdForChildProcess(
-      content::BrowserContext* browser_context,
-      int child_process_id);
-
-  // Same as GetStoragePartitionIdForChildProcess(), but uses a site instead.
-  //
-  // TODO(ajwong): Replace all uses of GetStoragePartitionIdForChildProcess()
-  // with this one.
+  // Allow the embedder to specify storage parititon id associated with a site.

[Charlie Reis, 2012/11/07 02:36:34]

Can you also update this to explain that partition_id is somehow a combination
of the partition_domain, partition_name, and in_memory info from below?  I'm
still not entirely clear how we expect those to be related in general (e.g., if
we're not talking about chrome-guest:// URLs), nor whether this code is going
away.

Maybe the right way is to say it's an embedder-specified string version of the
"storage partition config"?

[nasko, 2012/11/07 17:47:01]

Done.

   virtual std::string GetStoragePartitionIdForSite(
       content::BrowserContext* browser_context,
       const GURL& site);
@@ -290,6 +274,20 @@ class CONTENT_EXPORT ContentBrowserClient {
   virtual bool IsValidStoragePartitionId(BrowserContext* browser_context,
                                          const std::string& partition_id);
 
+  // Allow the embedder to provide storage parititon description associated with

[Charlie Reis, 2012/11/07 01:40:54]

nit: Allows
nit: provide a
s/associated with/for/

[Charlie Reis, 2012/11/07 02:36:34]

Also, s/description/configuration/.  We've already got enough terms for it, so
let's stick with the one from the method name.  :)

(Unless we settle on StoragePartitionDescriptor, which appears to have the same
info...)  :-/

[nasko, 2012/11/07 17:47:01]

Done.

[nasko, 2012/11/07 17:47:01]

Done.

+  // a site. Storage can be split into partition domains, which are independent

[Charlie Reis, 2012/11/07 01:40:54]

This sentence is hard for me to understand.  Can we tie it back to the
description you mentioned on the line above?  Maybe something like:

A storage partition description includes a domain of the embedder's choice, an
optional name within that domain, and whether the partition is in-memory only.

[nasko, 2012/11/07 17:47:01]

Done.

+  // from each other. The |partition_domain| is an arbitrary string, specifying

[awong, 2012/11/07 01:14:11]

Please state the formating constraints (eg., what's the encoding, can
partition_domain and name contain slashes, etc.)

[nasko, 2012/11/07 17:47:01]

Done.

+  // the domain in which partitions live (similar to namespace). Within a
+  // domain, partitions can be uniquely identified by the combination of
+  // |partition_name| and |in_memory| values. When a partition is not to be
+  // persisted, the |in_memory| value should be set to true.

[awong, 2012/11/07 01:14:11]

should -> will

[Charlie Reis, 2012/11/07 01:40:54]

Hmm, I think I agree with Nasko's wording (should).  In a sense, this is
documentation for anyone implementing this interface, so they need to know that
they should set the value to true.

[awong, 2012/11/07 01:43:46]

I tend to think of function comments as hard specs and should feels weaker since
no implementation that leave it as false would be correct.  But don't feel
strongly enough to argue. Either way works. :)

[nasko, 2012/11/07 17:47:01]

Done.

[nasko, 2012/11/07 17:47:01]

Done.

+  virtual void GetStoragePartitionConfigForSite(
+      content::BrowserContext* browser_context,
+      const GURL& site,
+      std::string* partition_domain,
+      std::string* partition_name,
+      bool* in_memory);
+
   // Create and return a new quota permission context.
   virtual QuotaPermissionContext* CreateQuotaPermissionContext();