Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Unified Diff: chrome/browser/profiles/profile_impl_io_data.cc

Issue 11234032: Webview tag creation should be using storage partitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removing the custom format of partition id. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_impl_io_data.cc
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index 2a539271da80b2aaa6c6cd669838b6505a1eb27e..4c6d76fd4ba61b6cba73b4ed96f7db41ac512340 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -211,9 +211,9 @@ ProfileImplIOData::Handle::GetIsolatedAppRequestContextGetter(
const FilePath& partition_path,
bool in_memory) const {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- // TODO(nasko): Check that the partition_path is not the same as the
- // base profile path. We expect isolated partition, which will never go
- // to the default profile path.
+ // Check that the partition_path is not the same as the base profile path. We
+ // expect isolated partition, which will never go to the default profile path.
+ CHECK(partition_path != profile_->GetPath());
LazyInitialize();
// Keep a map of request context getters, one per requested storage partition.
@@ -243,10 +243,7 @@ ProfileImplIOData::Handle::GetIsolatedMediaRequestContextGetter(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
// We must have a non-default path, or this will act like the default media
// context.
- //
- // TODO(nasko): Check that the partition_path is not the same as the
- // base profile path. We expect isolated partition, which will never go
- // to the default profile path.
+ CHECK(partition_path != profile_->GetPath());
LazyInitialize();
// Keep a map of request context getters, one per requested storage partition.

Powered by Google App Engine
This is Rietveld 408576698