Webview tag creation should be using storage partitions.

content/browser/storage_partition_impl_map.h

Index: content/browser/storage_partition_impl_map.h
diff --git a/content/browser/storage_partition_impl_map.h b/content/browser/storage_partition_impl_map.h
index 9e5c6d624cd954903f31f7913f3f8298a75035ad..4408a69492515cbba7a45b8ea5fe94bae0c3c358 100644
--- a/content/browser/storage_partition_impl_map.h
+++ b/content/browser/storage_partition_impl_map.h
@@ -10,6 +10,7 @@
 
 #include "base/callback_forward.h"
 #include "base/supports_user_data.h"
+#include "content/browser/storage_partition_impl.h"
 #include "content/public/browser/browser_context.h"
 
 class FilePath;
@@ -17,7 +18,6 @@ class FilePath;
 namespace content {
 
 class BrowserContext;
-class StoragePartitionImpl;
 
 // A std::string to StoragePartition map for use with SupportsUserData APIs.
 class StoragePartitionImplMap : public base::SupportsUserData::Data {
@@ -27,7 +27,9 @@ class StoragePartitionImplMap : public base::SupportsUserData::Data {
   virtual ~StoragePartitionImplMap();
 
   // This map retains ownership of the returned StoragePartition objects.
-  StoragePartitionImpl* Get(const std::string& partition_id);
+  StoragePartitionImpl* Get(const std::string& partition_domain,
+                            const std::string& partition_name,
+                            const bool& in_memory);

[awong, 2012/11/02 21:56:13]

don't pass primitives by const&!!!!!!!

[nasko, 2012/11/03 00:36:24]

Done.

 
   void ForEach(const BrowserContext::StoragePartitionCallback& callback);
 
@@ -41,7 +43,16 @@ class StoragePartitionImplMap : public base::SupportsUserData::Data {
   void PostCreateInitialization(StoragePartitionImpl* partition);
 
   BrowserContext* browser_context_;  // Not Owned.
-  std::map<std::string, StoragePartitionImpl*> partitions_;
+
+  // Boolean indicating whether we have initialized the ResourceContext for
+  // the |browser_context_| this map is associated with.
+  bool resource_context_initialized_;
+
+  typedef std::map<StoragePartitionImpl::StoragePartitionDescriptor,

[awong, 2012/11/02 21:56:13]

typedefs should go at the start of their private:/public: section.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Declaration_Order

[nasko, 2012/11/03 00:36:24]

Done.

+                   StoragePartitionImpl*,
+                   StoragePartitionImpl::StoragePartitionDescriptorLess>
+      PartitionsMap;
+  PartitionsMap partitions_;
 };
 
 }  // namespace content