Webview tag creation should be using storage partitions.

content/browser/browser_plugin/browser_plugin_embedder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 
 #include "base/stl_util.h"
 #include "content/browser/browser_plugin/browser_plugin_embedder_helper.h"
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/browser_plugin/browser_plugin_host_factory.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/browser_plugin_messages.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/common/url_constants.h"
+#include "net/base/escape.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
 #include "ui/gfx/size.h"
 
 namespace content {
 
 // static
 BrowserPluginHostFactory* BrowserPluginEmbedder::factory_ = NULL;
 
 BrowserPluginEmbedder::BrowserPluginEmbedder(
     WebContentsImpl* web_contents,
@@ skipping 44 matching lines @@
 }
 
 void BrowserPluginEmbedder::CreateGuest(
     RenderViewHost* render_view_host,
     int instance_id,
     const BrowserPluginHostMsg_CreateGuest_Params& params) {
   WebContentsImpl* guest_web_contents = NULL;
   BrowserPluginGuest* guest = GetGuestByInstanceID(instance_id);
   CHECK(!guest);
 
+  std::string url_encoded_partition;
+  bool persist_storage = params.persist_storage;
+
+  // Validate that the partition id coming from the renderer is valid UTF-8,
+  // since we depend on this in other parts of the code, such as FilePath
+  // creation.
+  if (IsStringUTF8(params.storage_partition_id)) {
+    url_encoded_partition = net::EscapeQueryParamValue(
+        params.storage_partition_id, false);
+  } else {
+    // Since the partition id is not valid UTF-8, fallback to the default
+    // in-memory partition.

[awong, 2012/11/07 01:14:11]

Not sure how I feel about this.  It's okay, but killing the renderer actually
feels better...

[awong, 2012/11/07 01:14:11]

Not sure how I feel about this. If the renderer is misbehaving, shouldn't we
kill it rather than use fallback behavior which might mask the bug?

[Charlie Reis, 2012/11/07 02:36:34]

I don't know if we have access to BrowserMessageFilter::BadMessageReceived here
or just want to do something similar, but that's one way to kill the renderer
when it does something unexpected like this.

[nasko, 2012/11/07 17:47:01]

As Charlie pointed in offline discussion, FilterURL already has similar behavior
of not killing renderer, but masking the value and letting it continue.

[nasko, 2012/11/07 17:47:01]

BadMessageReceived is a MessageFilter method that cannot be invoked without
having a filter object. It only does a KillProcess, so I've just done that.

+    url_encoded_partition.clear();
+    persist_storage = false;
+  }
+
   const std::string& host =
       render_view_host->GetSiteInstance()->GetSiteURL().host();
+
+  // The SiteInstance of a given webview tag is based on the fact that it's a
+  // guest process in addition to which platform application the tag belongs to
+  // and what storage partition is in use, rather than the URL that the tag is
+  // being navigated to.
+  GURL guest_site(
+      base::StringPrintf("%s://%s/%s?%s", chrome::kGuestScheme,
+                         host.c_str(), persist_storage ? "persist" : "",
+                         url_encoded_partition.c_str()));
+  SiteInstance* guest_site_instance = SiteInstance::CreateForURL(
+      web_contents()->GetBrowserContext(), guest_site);
+
   guest_web_contents = WebContentsImpl::CreateGuest(
       web_contents()->GetBrowserContext(),
-      host,
+      guest_site_instance,
       instance_id,
       params);
 
   guest = guest_web_contents->GetBrowserPluginGuest();
   guest->set_embedder_web_contents(
       static_cast<WebContentsImpl*>(web_contents()));
 
   RendererPreferences* guest_renderer_prefs =
       guest_web_contents->GetMutableRendererPrefs();
   // Copy renderer preferences (and nothing else) from the embedder's
@@ skipping 177 matching lines @@
       bool visible = *Details<bool>(details).ptr();
       WebContentsVisibilityChanged(visible);
       break;
     }
     default:
       NOTREACHED() << "Unexpected notification type: " << type;
   }
 }
 
 }  // namespace content