Webview tag creation should be using storage partitions.

content/browser/storage_partition_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_STORAGE_PARTITION_IMPL_H_
 #define CONTENT_BROWSER_STORAGE_PARTITION_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "content/browser/appcache/chrome_appcache_service.h"
 #include "content/browser/dom_storage/dom_storage_context_impl.h"
 #include "content/browser/in_process_webkit/indexed_db_context_impl.h"
 #include "content/public/browser/storage_partition.h"
 
 namespace content {
 
 class StoragePartitionImpl : public StoragePartition {
  public:
+  // Each StoragePartition is uniquely identified by which partition domain
+  // it belongs to (such as an app or the browser itself), the user supplied
+  // partition name and the bit indicating whether it should be persisted on
+  // disk or not. This structure contains those elements and is used as
+  // uniqueness key to lookup StoragePartition objects in the global map.
+  //
+  // Note: It is equivalent, though not identical to the same structure that
+  // lives in chrome profiles. The difference is that this one has
+  // partition_domain and partition_name separate, while the latter one has
+  // the path produced by combining the two pieces together.

[awong, 2012/11/02 21:56:13]

Cite bug 159193 as the fix for this forkage.

[nasko, 2012/11/03 00:36:24]

Done.

+  struct StoragePartitionDescriptor {
+    const std::string partition_domain;
+    const std::string partition_name;
+    const bool in_memory;
+
+    StoragePartitionDescriptor(const std::string& domain,
+                               const std::string& partition,
+                               const bool& in_memory_only)
+      : partition_domain(domain),
+        partition_name(partition),
+        in_memory(in_memory_only) {}
+  };

[awong, 2012/11/02 21:56:13]

need newline.

[nasko, 2012/11/03 00:36:24]

Done.

+  // Functor for operator <.
+  struct StoragePartitionDescriptorLess {

[awong, 2012/11/02 21:56:13]

Can this type be private?

[nasko, 2012/11/03 00:36:24]

Done.

+    bool operator()(const StoragePartitionDescriptor& lhs,
+                    const StoragePartitionDescriptor& rhs) const {
+      if (lhs.partition_domain != rhs.partition_domain)
+        return lhs.partition_domain < rhs.partition_domain;
+      else if (lhs.partition_name != rhs.partition_name)
+        return lhs.partition_name < rhs.partition_name;
+      else if (lhs.in_memory != rhs.in_memory)
+        return lhs.in_memory < rhs.in_memory;
+      else
+        return false;
+    }
+  };
+
   virtual ~StoragePartitionImpl();
 
   // TODO(ajwong): Break the direct dependency on |context|. We only
   // need 3 pieces of info from it.
-  static StoragePartitionImpl* Create(BrowserContext* context,
-                                      const std::string& partition_id,
-                                      const FilePath& profile_path);
+  static StoragePartitionImpl* Create(
+      BrowserContext* context,
+      const StoragePartitionDescriptor& partition_id,

[awong, 2012/11/02 21:56:13]

What's your thoughts on hiding the Descriptor struct completely from the public
API?  Cleaner or not cleaner?

[nasko, 2012/11/03 00:36:24]

Create is only called by SPIM::Get, so it is not really "public". Now that
you've mentioned it, since SPIM is a friend to this class, I've made this method
private.

+      const FilePath& profile_path);
 
   // StoragePartition interface.
   virtual FilePath GetPath() OVERRIDE;
   virtual net::URLRequestContextGetter* GetURLRequestContext() OVERRIDE;
   virtual net::URLRequestContextGetter* GetMediaURLRequestContext() OVERRIDE;
   virtual quota::QuotaManager* GetQuotaManager() OVERRIDE;
   virtual ChromeAppCacheService* GetAppCacheService() OVERRIDE;
   virtual fileapi::FileSystemContext* GetFileSystemContext() OVERRIDE;
   virtual webkit_database::DatabaseTracker* GetDatabaseTracker() OVERRIDE;
   virtual DOMStorageContextImpl* GetDOMStorageContext() OVERRIDE;
   virtual IndexedDBContextImpl* GetIndexedDBContext() OVERRIDE;
 
  private:
   friend class StoragePartitionImplMap;
 
+  // Returns the relative path from the profile's base directory, to the
+  // directory that holds all the state for storage contexts in
+  // |partition_descriptor|.
+  static FilePath GetStoragePartitionPath(
+      const StoragePartitionDescriptor& partition_descriptor);
+
   StoragePartitionImpl(
       const FilePath& partition_path,
       quota::QuotaManager* quota_manager,
       ChromeAppCacheService* appcache_service,
       fileapi::FileSystemContext* filesystem_context,
       webkit_database::DatabaseTracker* database_tracker,
       DOMStorageContextImpl* dom_storage_context,
       IndexedDBContextImpl* indexed_db_context);
 
   // Used by StoragePartitionImplMap.
@@ skipping 21 matching lines @@
   scoped_refptr<webkit_database::DatabaseTracker> database_tracker_;
   scoped_refptr<DOMStorageContextImpl> dom_storage_context_;
   scoped_refptr<IndexedDBContextImpl> indexed_db_context_;
 
   DISALLOW_COPY_AND_ASSIGN(StoragePartitionImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_STORAGE_PARTITION_IMPL_H_