chrome/renderer/chrome_render_view_observer.cc - Issue 11233065: Rename <browser> shim to <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_view_observer.cc

Issue 11233065: Rename <browser> shim to <webview> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed WebViewTest.Shim. Thanks Mihai! Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_render_view_observer.cc

diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc

index 3521944bf122cbaf93729e5d09bac85fdf90e980..71863c242cf3d91111ff210a45654057625d7ef6 100644

--- a/chrome/renderer/chrome_render_view_observer.cc

+++ b/chrome/renderer/chrome_render_view_observer.cc

@@ -493,8 +493,8 @@ bool ChromeRenderViewObserver::allowWebComponents(const WebDocument& document,

if (extension->HasAPIPermission(APIPermission::kAppWindow))

return true;

- // The <browser> tag is implemented via Shadow DOM.

- if (extension->HasAPIPermission(APIPermission::kBrowserTag))

+ // The <webview> tag is implemented via Shadow DOM.

+ if (extension->HasAPIPermission(APIPermission::kWebView))

return true;

if (extension->HasAPIPermission(APIPermission::kExperimental))