Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6209)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 11232068: Extract renderer-side favicon downloading code into separate helper class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move UpdateFaviconURL code into helper Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 4fa5c7d8c393adc2dbfb8b158f8086257b3bd74f..e58c303bc7124d8c311c7fb5c48c3bb1d853d86f 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -43,6 +43,7 @@
#include "chrome/renderer/extensions/miscellaneous_bindings.h"
#include "chrome/renderer/extensions/resource_request_policy.h"
#include "chrome/renderer/external_extension.h"
+#include "chrome/renderer/favicon_helper.h"
#include "chrome/renderer/loadtimes_extension_bindings.h"
#include "chrome/renderer/net/renderer_net_predictor.h"
#include "chrome/renderer/page_click_tracker.h"
@@ -276,9 +277,10 @@ void ChromeContentRendererClient::RenderViewCreated(
page_click_tracker->AddListener(autofill_agent);
TranslateHelper* translate = new TranslateHelper(render_view);
+ FaviconHelper* favicon = new FaviconHelper(render_view);
joth 2012/10/24 22:02:23 whitespace nit
Cait (Slow) 2012/10/25 20:29:23 Done.
new ChromeRenderViewObserver(
render_view, content_settings, chrome_observer_.get(),
- extension_dispatcher_.get(), translate);
+ extension_dispatcher_.get(), translate, favicon);
new PepperHelper(render_view);

Powered by Google App Engine
This is Rietveld 408576698