Make sure sideload wipeout doesn't interfere with the tests.

chrome/browser/ui/views/extensions/disabled_extensions_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/disabled_extensions_view.h"
 
 #include "base/metrics/histogram.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/singleton_tabs.h"
+#include "chrome/browser/prefs/pref_service.h"
 #include "chrome/common/extensions/feature_switch.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/user_metrics.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/theme_resources.h"
 #include "ui/base/accessibility/accessible_view_state.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/views/controls/button/text_button.h"
 #include "ui/views/controls/label.h"
@@ skipping 11 matching lines @@
 const int kColumnPadding = 4;
 const int kExtensionListPadding = 20;
 const int kImagePadding = 7;
 const int kLeftColumnPadding = 3;
 const int kInsetBottomRight = 13;
 const int kInsetTopLeft = 14;
 const int kHeadlineMessagePadding = 4;
 const int kHeadlineRowPadding = 10;
 const int kMessageBubblePadding = 11;
 
+// How often to show the disabled extension (sideload wipeout) bubble.
+const int kShowSideloadWipeoutBubbleMax = 3;
+
 // How many extensions to show in the bubble (max).
 const int kMaxExtensionsToShow = 7;
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // DisabledExtensionsView
 
 // static
-bool DisabledExtensionsView::MaybeShow(Browser* browser,
+void DisabledExtensionsView::MaybeShow(Browser* browser,
                                        views::View* anchor_view) {
 #if !defined(OS_WIN)

[Aaron Boodman, 2012/10/23 15:20:20]

Shouldn't be necessary anymore, right?

-  // We are targeting registry-installed extensions, which is Windows-specific,
+  // We are targeting registry-installed extensions, which are Windows-specific,
   // and extensions marked internal and not from the web store, which are mostly
   // problematic on Windows.
-  return false;
+  return;
 #endif
 
   if (!extensions::FeatureSwitch::sideload_wipeout()->IsEnabled())
-    return false;
+    return;
 
   static bool done_showing_ui = false;
   if (done_showing_ui)
-    return false;  // Only show the bubble once per launch.
+    return;  // Only show the bubble once per launch.
+
+  // A pref that counts how often the bubble has been shown.
+  IntegerPrefMember sideload_wipeout_bubble_shown;
+
+  sideload_wipeout_bubble_shown.Init(
+      prefs::kExtensionsSideloadWipeoutBubbleShown,
+          browser->profile()->GetPrefs(), NULL);
+  int bubble_shown_count = sideload_wipeout_bubble_shown.GetValue();
+  if (bubble_shown_count >= kShowSideloadWipeoutBubbleMax)
+    return;
+  sideload_wipeout_bubble_shown.SetValue(++bubble_shown_count);
 
   // Fetch all disabled extensions.
   ExtensionService* extension_service =
       extensions::ExtensionSystem::Get(
           browser->profile())->extension_service();
   scoped_ptr<const ExtensionSet> wiped_out(
       extension_service->GetWipedOutExtensions());
   if (wiped_out->size()) {
     DisabledExtensionsView* bubble_delegate =
         new DisabledExtensionsView(
             anchor_view, browser, wiped_out.release());
     views::BubbleDelegateView::CreateBubble(bubble_delegate);
     bubble_delegate->StartFade(true);
 
     done_showing_ui = true;
-    return true;
   }
-
-  return false;
 }
 
 DisabledExtensionsView::DisabledExtensionsView(
     views::View* anchor_view,
     Browser* browser,
     const ExtensionSet* wiped_out)
     : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
       browser_(browser),
       wiped_out_(wiped_out),
       headline_(NULL),
@@ skipping 17 matching lines @@
         UserMetricsAction("DisabledExtension_SettingsButton"));
     browser_->OpenURL(
         content::OpenURLParams(GURL(chrome::kChromeUIExtensionsURL),
                                content::Referrer(),
                                NEW_FOREGROUND_TAB,
                                content::PAGE_TRANSITION_LINK,
                                false));
 
   } else if (sender == dismiss_button_) {
     content::RecordAction(UserMetricsAction("DisabledExtension_Dismiss"));
-    // No action required. Close will happen below.
+    IntegerPrefMember sideload_wipeout_bubble_shown;

[Aaron Boodman, 2012/10/23 15:23:38]

I think that it's only supposed to be shown once, so long as the user interacts
with the bubble in any way - clicking any of the buttons or links.

It only shows multiple times if the user completely ignores it and the browser
closes without any interaction.

[Finnur, 2012/10/23 15:43:10]

That makes sense for the buttons, but I'm not as sure about the 'Learn more'
link. Pressing the link closes the bubble and takes you to the help center. You
can't go back to the bubble if the help center convinces you that you should go
enable extensions. I don't feel strongly about it though and could be convinced
otherwise. Just want to make sure it is not overlooked.

On 2012/10/23 15:23:38, Aaron Boodman wrote:

[Peter Ludwig, 2012/10/23 16:11:01]

It's fine for the bubble to dismiss (and to never appear again) after "Learn
more" is clicked.  The help article will describe how to get to the extensions
settings page from the hot dogs menu.

The butterbar should show the first time the user goes to the extension settings
page regardless of if they got there by clicking the "Extension settings" button
on the bubble, or by clicking "OK, great" and then later clicking though the hot
dogs menu to get to the extension settings page.

On 2012/10/23 15:43:10, Finnur wrote:

[Finnur, 2012/10/23 16:55:44]

Sounds good.
Yup, that's how it works today.

+    sideload_wipeout_bubble_shown.Init(
+        prefs::kExtensionsSideloadWipeoutBubbleShown,
+            browser_->profile()->GetPrefs(), NULL);
+    sideload_wipeout_bubble_shown.SetValue(kShowSideloadWipeoutBubbleMax);
   } else {
     NOTREACHED();
   }
 
   GetWidget()->Close();
 }
 
 void DisabledExtensionsView::LinkClicked(
     views::Link* source, int event_flags) {
   content::RecordAction(UserMetricsAction("DisabledExtension_LearnMore"));
@@ skipping 147 matching lines @@
   layout->AddView(settings_button_);
   dismiss_button_ = new views::NativeTextButton(this,
       l10n_util::GetStringUTF16(IDS_OPTIONS_SIDELOAD_WIPEOUT_DISMISS));
   dismiss_button_->SetFont(
       dismiss_button_->font().DeriveFont(0, gfx::Font::BOLD));
   layout->AddView(dismiss_button_);
 
   content::RecordAction(
       UserMetricsAction("DisabledExtensionNotificationShown"));
 }