[views] "Hello, world" autofill imperative API dialog.

chrome/browser/ui/views/autofill/autofill_dialog_views.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_
+
+#include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
+#include "ui/views/window/dialog_delegate.h"
+
+class ConstrainedWindowViews;
+
+class AutofillDialogViews : public AutofillDialogView,

[Ilya Sherman, 2012/10/23 00:39:00]

nit: I believe this should be named AutofillDialogViewViews.

[Evan Stade, 2012/10/23 01:52:04]

that is one possible name for the class, but not the one I prefer.

+                            public views::DialogDelegate {
+ public:
+  explicit AutofillDialogViews(AutofillDialogController* controller);
+  virtual ~AutofillDialogViews();
+
+  // AutofillDialogView implementation:
+  virtual void Show() OVERRIDE;
+
+  // views::DialogDelegate implementation:
+  virtual string16 GetWindowTitle() const OVERRIDE;
+  virtual void DeleteDelegate() OVERRIDE;
+  virtual views::Widget* GetWidget() OVERRIDE;
+  virtual const views::Widget* GetWidget() const OVERRIDE;
+  virtual views::View* GetContentsView() OVERRIDE;
+  virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
+  virtual bool IsDialogButtonEnabled(ui::DialogButton button) const OVERRIDE;
+  virtual bool UseChromeStyle() const OVERRIDE;
+  virtual bool Cancel() OVERRIDE;
+  virtual bool Accept() OVERRIDE;
+
+  void InitChildViews();
+
+ private:
+  // Weak pointer, always non-NULL.
+  AutofillDialogController* controller_;

[Ilya Sherman, 2012/10/23 00:39:00]

nit: AutofillDialogController* const controller_;

[Evan Stade, 2012/10/23 01:52:04]

Done.

+
+  ConstrainedWindowViews* window_;

[Ilya Sherman, 2012/10/23 00:39:00]

nit: All class members should be documented, even if minimally just to reassure
the reader that the obvious guess is indeed correct.  Please describe this and
the other members for this class.

[Evan Stade, 2012/10/23 01:52:04]

Done.

+
+  // Owned by |window_|.
+  views::View* contents_;
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_