[Chromoting] The desktop process now creates a pre-connected pipe and passes (with some help of the…

remoting/host/desktop_process.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_DESKTOP_PROCESS_H_
 #define REMOTING_HOST_DESKTOP_PROCESS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "ipc/ipc_listener.h"
 
 namespace IPC {
 class ChannelProxy;
 }  // namespace IPC
 
 namespace remoting {
 
+class DesktopSessionAgent;
+
 class DesktopProcess : public IPC::Listener {
  public:
   explicit DesktopProcess(const std::string& daemon_channel_name);
-  ~DesktopProcess();
+  virtual ~DesktopProcess();
 
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
   virtual void OnChannelConnected(int32 peer_pid) OVERRIDE;
   virtual void OnChannelError() OVERRIDE;
 
   // Runs the desktop process.
   int Run();
 
  private:
-  // IPC channel connecting the desktop process with the daemon process.
-  scoped_ptr<IPC::ChannelProxy> daemon_channel_;
+  // Crashes the process in response to a daemon's request. The daemon passes
+  // the location of the code that detected the fatal error resulted in this
+  // request.

[Sergey Ulanov, 2012/10/24 20:12:01]

Not sure I understand why we need this. Is it because daemon process can't send
crash reports? Please explain in the comment.

[alexeypa (please no reviews), 2012/10/24 21:41:51]

It is explained at the declaration of ChromotingDaemonDesktopMsg_Crash message.
I added a reference to the comment.

+  void OnCrash(const std::string& function_name,
+               const std::string& file_name,
+               const int& line_number);
 
   // Name of the IPC channel connecting the desktop process with the daemon
   // process.
   std::string daemon_channel_name_;
 
+  // IPC channel connecting the desktop process with the daemon process.
+  scoped_ptr<IPC::ChannelProxy> daemon_channel_;
+
+  // Provides screen/audio capturing and input injection services for
+  // the network process.
+  scoped_ptr<DesktopSessionAgent> desktop_agent_;
+
   DISALLOW_COPY_AND_ASSIGN(DesktopProcess);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_DESKTOP_PROCESS_H_