Histogram argument related change

chrome/browser/chromeos/external_metrics.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/external_metrics.h"
 
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ skipping 17 matching lines @@
 #include "content/public/browser/user_metrics.h"
 
 using content::BrowserThread;
 using content::UserMetricsAction;
 
 namespace chromeos {
 
 // The interval between external metrics collections in seconds
 static const int kExternalMetricsCollectionIntervalSeconds = 30;
 
-class SystemHistogram : public base::Histogram {

[zel, 2012/10/24 01:11:00]

You can get rid of this class now and just expose CheckValues() and
CheckLinearValues() as functions.

[kaiwang, 2012/10/24 03:43:28]

Done.

+class SystemHistogram {
  public:
   static bool CheckValues(const std::string& name,
                           int minimum,
                           int maximum,
                           size_t bucket_count) {
     if (!base::Histogram::InspectConstructionArguments(
         name, &minimum, &maximum, &bucket_count))
       return false;
-    Histogram* histogram = base::StatisticsRecorder::FindHistogram(name);
+    HistogramBase* histogram = base::StatisticsRecorder::FindHistogram(name);
     if (!histogram)
       return true;
     return histogram->HasConstructionArguments(minimum, maximum, bucket_count);
   }
   static bool CheckLinearValues(const std::string& name, int maximum) {
     return CheckValues(name, 1, maximum, maximum + 1);
   }
 };
 
 ExternalMetrics::ExternalMetrics()
@@ skipping 208 matching lines @@
 void ExternalMetrics::ScheduleCollector() {
   bool result;
   result = BrowserThread::PostDelayedTask(
     BrowserThread::FILE, FROM_HERE,
     base::Bind(&chromeos::ExternalMetrics::CollectEventsAndReschedule, this),
     base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds));
   DCHECK(result);
 }
 
 }  // namespace chromeos