Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: webkit/compositor_bindings/web_layer_unittest.cc

Issue 11231017: Remove ::create factory functions from objects created via WebCompositorSupport (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix includes Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/compositor_bindings/web_layer_unittest.cc
diff --git a/webkit/compositor_bindings/web_layer_unittest.cc b/webkit/compositor_bindings/web_layer_unittest.cc
index ed94edbcadc72aa457614b96f6d1a7f6a66df23f..a62c3e75eb542ec41a8f689f81d6baf9f65a8d4e 100644
--- a/webkit/compositor_bindings/web_layer_unittest.cc
+++ b/webkit/compositor_bindings/web_layer_unittest.cc
@@ -6,9 +6,12 @@
#include "cc/thread.h"
#include "cc/test/compositor_fake_web_graphics_context_3d.h"
-#include "web_layer_impl.h"
-#include "web_layer_tree_view_impl.h"
-#include "web_layer_tree_view_test_common.h"
+#include "webkit/compositor_bindings/test/web_layer_tree_view_test_common.h"
+#include "webkit/compositor_bindings/web_layer_impl.h"
+#include "webkit/compositor_bindings/web_layer_tree_view_impl.h"
+#include "webkit/compositor_bindings/web_content_layer_impl.h"
+#include "webkit/compositor_bindings/web_solid_color_layer_impl.h"
+#include "webkit/compositor_bindings/web_external_texture_layer_impl.h"
#include <public/WebContentLayer.h>
#include <public/WebContentLayerClient.h>
#include <public/WebExternalTextureLayer.h>
@@ -49,7 +52,7 @@ public:
virtual void SetUp()
{
- m_rootLayer.reset(WebLayer::create());
+ m_rootLayer.reset(new WebLayerImpl);
EXPECT_CALL(m_client, scheduleComposite()).Times(AnyNumber());
m_view.reset(new WebLayerTreeViewImpl(&m_client));
EXPECT_TRUE(m_view->initialize(WebLayerTreeView::Settings(), scoped_ptr<cc::Thread>(NULL)));
@@ -68,7 +71,7 @@ public:
protected:
MockWebLayerTreeViewClient m_client;
- scoped_ptr<WebLayer> m_rootLayer;
+ scoped_ptr<WebLayerImpl> m_rootLayer;
scoped_ptr<WebLayerTreeViewImpl> m_view;
};
@@ -78,7 +81,7 @@ TEST_F(WebLayerTest, Client)
{
// Base layer.
EXPECT_CALL(m_client, scheduleComposite()).Times(AnyNumber());
- scoped_ptr<WebLayer> layer(WebLayer::create());
+ scoped_ptr<WebLayer> layer(new WebLayerImpl);
layer->setDrawsContent(true);
m_rootLayer->addChild(layer.get());
Mock::VerifyAndClearExpectations(&m_client);
@@ -107,7 +110,7 @@ TEST_F(WebLayerTest, Client)
EXPECT_TRUE(layer->masksToBounds());
EXPECT_CALL(m_client, scheduleComposite()).Times(AnyNumber());
- scoped_ptr<WebLayer> otherLayer(WebLayer::create());
+ scoped_ptr<WebLayer> otherLayer(new WebLayerImpl);
m_rootLayer->addChild(otherLayer.get());
EXPECT_CALL(m_client, scheduleComposite()).Times(AtLeast(1));
layer->setMaskLayer(otherLayer.get());
@@ -131,7 +134,7 @@ TEST_F(WebLayerTest, Client)
// Texture layer.
EXPECT_CALL(m_client, scheduleComposite()).Times(AtLeast(1));
- scoped_ptr<WebExternalTextureLayer> textureLayer(WebExternalTextureLayer::create());
+ scoped_ptr<WebExternalTextureLayer> textureLayer(new WebExternalTextureLayerImpl(NULL));
m_rootLayer->addChild(textureLayer->layer());
Mock::VerifyAndClearExpectations(&m_client);
@@ -158,7 +161,7 @@ TEST_F(WebLayerTest, Client)
#endif // WEBCONTENTLAYERCLIENT_HAS_CANPAINTLCDTEXT
EXPECT_CALL(m_client, scheduleComposite()).Times(AnyNumber());
- scoped_ptr<WebContentLayer> contentLayer(WebContentLayer::create(&contentClient));
+ scoped_ptr<WebContentLayer> contentLayer(new WebContentLayerImpl(&contentClient));
m_rootLayer->addChild(contentLayer->layer());
Mock::VerifyAndClearExpectations(&m_client);
@@ -169,7 +172,7 @@ TEST_F(WebLayerTest, Client)
// Solid color layer.
EXPECT_CALL(m_client, scheduleComposite()).Times(AtLeast(1));
- scoped_ptr<WebSolidColorLayer> solidColorLayer(WebSolidColorLayer::create());
+ scoped_ptr<WebSolidColorLayer> solidColorLayer(new WebSolidColorLayerImpl);
m_rootLayer->addChild(solidColorLayer->layer());
Mock::VerifyAndClearExpectations(&m_client);
« no previous file with comments | « webkit/compositor_bindings/web_layer_impl.cc ('k') | webkit/compositor_bindings/web_scrollbar_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698