chrome/browser/android/tab_base_android_impl.cc - Issue 11231017: Remove ::create factory functions from objects created via WebCompositorSupport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_base_android_impl.cc

Issue 11231017: Remove ::create factory functions from objects created via WebCompositorSupport (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: android fixes + no .gitmodules Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/tab_base_android_impl.cc

diff --git a/chrome/browser/android/tab_base_android_impl.cc b/chrome/browser/android/tab_base_android_impl.cc

index b2f639d494c71d957f116116b7e499ea15e3a37a..9532a2c459e31dd18d6665171c689f932b3a2004 100644

--- a/chrome/browser/android/tab_base_android_impl.cc

+++ b/chrome/browser/android/tab_base_android_impl.cc

@@ -13,6 +13,8 @@

#include "content/public/browser/web_contents.h"

#include "googleurl/src/gurl.h"

#include "jni/TabBase_jni.h"

+#include "third_party/WebKit/Source/Platform/chromium/public/Platform.h"

+#include "third_party/WebKit/Source/Platform/chromium/public/WebCompositorSupport.h"

#include "third_party/WebKit/Source/Platform/chromium/public/WebLayer.h"

#include "ui/gfx/android/window_android.h"

@@ -58,8 +60,9 @@ TabBaseAndroidImpl::TabBaseAndroidImpl(JNIEnv* env,

jobject obj,

WebContents* web_contents,

WindowAndroid* window_android)

- : web_contents_(web_contents),

- tab_layer_(WebKit::WebLayer::create()) {

+ : web_contents_(web_contents) {

+ tab_layer_.reset(

+ WebKit::Platform::current()->compositorSupport()->createLayer);

aelias_OOO_until_Jul13 2012/10/23 03:22:55 This won't compile, missing parens after createLay

InitTabHelpers(web_contents);

WindowAndroidHelper::FromWebContents(web_contents)->

SetWindowAndroid(window_android);

« no previous file with comments | « chrome/android/testshell/tab_manager.cc ('k') | content/shell/android/shell_manager.cc » ('j') | no next file with comments »