Adding commandline switch and user pref for autofill server url.

chrome/browser/autofill/autofill_download_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <list>
 
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/test/test_timeouts.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_download.h"
 #include "chrome/browser/autofill/autofill_field.h"
 #include "chrome/browser/autofill/autofill_metrics.h"
 #include "chrome/browser/autofill/autofill_type.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/common/form_data.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
+#include "chrome/test/base/testing_pref_service.h"

[Albert Bodenhamer, 2012/10/23 23:34:17]

Alphabetize

[ahutter, 2012/10/24 17:33:45]

Reverting all changes to this file.

 #include "content/public/test/test_browser_thread.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_request_status.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputElement.h"
 
 using content::BrowserThread;
 using WebKit::WebInputElement;
+using testing::HasSubstr;
+using testing::Not;
 
 namespace {
 
 class MockAutofillMetrics : public AutofillMetrics {
  public:
   MockAutofillMetrics() {}
   MOCK_CONST_METHOD1(LogServerQueryMetric, void(ServerQueryMetric metric));
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockAutofillMetrics);
 };
 
 // Call |fetcher->OnURLFetchComplete()| as the URLFetcher would when
 // a response is received.  Params allow caller to set fake status.
 void FakeOnURLFetchComplete(net::TestURLFetcher* fetcher,
                             int response_code,
                             const std::string& response_body) {
   fetcher->set_url(GURL());
   fetcher->set_status(net::URLRequestStatus());
   fetcher->set_response_code(response_code);
   fetcher->SetResponseString(response_body);
 
   fetcher->delegate()->OnURLFetchComplete(fetcher);
 }
 
 }  // namespace
 
+class AutofillDownloadUrlTest : public testing::Test {
+ public:
+  AutofillDownloadUrlTest() {}
+
+ protected:
+  virtual void SetUp() {
+    pref_service_.reset(new TestingPrefService());
+  }
+
+  scoped_ptr<TestingPrefService> pref_service_;
+};
+
+TEST_F(AutofillDownloadUrlTest, CheckDefaultUrls) {
+  std::string request_url =
+      AutofillDownloadUrl(pref_service_.get()).
+      GetAutofillRequestUrl().spec();
+  EXPECT_THAT(request_url, HasSubstr("clients1.google.com"));
+  EXPECT_THAT(request_url, HasSubstr("/tbproxy/"));
+  EXPECT_THAT(request_url, HasSubstr("/af/"));
+  EXPECT_THAT(request_url, HasSubstr("/query"));
+  EXPECT_THAT(request_url, Not(HasSubstr("/upload")));
+  EXPECT_THAT(request_url, HasSubstr("?client="));
+
+
+  std::string upload_url =
+      AutofillDownloadUrl(pref_service_.get()).
+      GetAutofillUploadUrl().spec();
+  EXPECT_THAT(upload_url, HasSubstr("clients1.google.com"));
+  EXPECT_THAT(upload_url, HasSubstr("/tbproxy/"));
+  EXPECT_THAT(upload_url, HasSubstr("/af/"));
+  EXPECT_THAT(upload_url, HasSubstr("/upload"));
+  EXPECT_THAT(upload_url, Not(HasSubstr("/query")));
+  EXPECT_THAT(upload_url, HasSubstr("?client="));
+}

[Ilya Sherman, 2012/10/23 23:45:13]

nit: Since this code is testing the AutofillDownloadUrl class, it should be in a
separate test file, named autofill_download_url_unittest.cc

[ahutter, 2012/10/24 17:33:45]

Reverting all changes to this file.

+
+
 // This tests AutofillDownloadManager. AutofillDownloadTest implements
 // AutofillDownloadManager::Observer and creates an instance of
 // AutofillDownloadManager. Then it records responses to different initiated
 // requests, which are verified later. To mock network requests
 // TestURLFetcherFactory is used, which creates URLFetchers that do not
 // go over the wire, but allow calling back HTTP responses directly.
 // The responses in test are out of order and verify: successful query request,
 // successful upload request, failed upload request.
 class AutofillDownloadTest : public AutofillDownloadManager::Observer,
                              public testing::Test {
@@ skipping 431 matching lines @@
                                                   mock_metric_logger));
   // No responses yet
   EXPECT_EQ(static_cast<size_t>(0), responses_.size());
 
   fetcher = factory.GetFetcherByID(3);
   ASSERT_TRUE(fetcher);
   FakeOnURLFetchComplete(fetcher, 200, std::string(responses[0]));
   ASSERT_EQ(static_cast<size_t>(1), responses_.size());
   EXPECT_EQ(responses[0], responses_.front().response);
 }