Issue 11230028: Split ResourceContext into its own file, and make it compile on iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11230028: Split ResourceContext into its own file, and make it compile on iOS (Closed)

Created:
8 years, 2 months ago by stuartmorgan

Modified:
8 years, 1 month ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split ResourceContext into its own file, and make it compile on iOS ResourceContext's constructor and destructor are needed on iOS since profile_io_data has a subclass of the interface, but the rest of the file isn't. Also removes a bunch of #include/using cruft in resource_context_impl.cc BUG=None

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -24 lines)			Patch
A	content/browser/resource_context.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	content/browser/resource_context_impl.cc	View	3 chunks	+0 lines, -24 lines	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

8 years, 1 month ago (2012-11-13 16:23:48 UTC) #4

sorry just saw this. for future reference if I don't respond within a few hours,
it's because I missed the change.

I still think this should just be an ifdef block in resource_context_impl.cc,
i.e. to avoid adding a new file. there'll be one extra ifdef block for the other
functions you don't need, but the gyp files will have one less entry...

Expand Messages | Collapse Messages