Issue 11230025: Initialize root resource ID only once for Drive API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11230025: Initialize root resource ID only once for Drive API. (Closed)

Created:
8 years, 2 months ago by kochi

Modified:
8 years, 2 months ago

Reviewers:
satorux1

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Haruki Sato

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Initialize root resource ID only once for Drive API. AboutResource() is refreshed multiple times but we only have to initialize the root directory resource ID only once as it will not change. As Drive API is disabled for now, we don't have any test to verify this at this moment. BUG=152230 TEST=none

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/chromeos/drive/drive_feed_loader.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/11230025/1

8 years, 2 months ago (2012-10-22 08:31:33 UTC) #3

kochi

On 2012/10/22 08:31:33, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

8 years, 2 months ago (2012-10-22 08:49:13 UTC) #4

kochi

8 years, 2 months ago (2012-10-24 04:26:49 UTC) #5

On 2012/10/22 08:49:13, Takayoshi Kochi wrote:
> On 2012/10/22 08:31:33, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/kochi%2540chromium.org/11230025/1
> 
> This depends on
> http://codereview.chromium.org/11227020/
> 
> and I'll wait for it to land.

I'll merge this change to http://codereview.chromium.org/11227020/
Closing.

Expand Messages | Collapse Messages