[NaCl SDK] Refactor sdk_update*.

native_client_sdk/src/build_tools/sdk_tools/commands/info.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import logging
+import manifest_util
+
+__all__ = ['Info']

[noelallen1, 2012/10/29 23:11:30]

What is this exactly?

[binji, 2012/10/29 23:51:18]

Removed.

+
+def Info(manifest, bundle_names):
+  valid_bundles = [bundle.name for bundle in manifest.GetBundles()]
+  valid_bundles = set(bundle_names) & set(valid_bundles)
+  invalid_bundles = set(bundle_names) - valid_bundles
+  if invalid_bundles:
+    logging.warn('Unknown bundle(s): %s\n' % (', '.join(invalid_bundles)))
+
+  for bundle_name in bundle_names:
+    if bundle_name not in valid_bundles:
+      continue
+
+    bundle = manifest.GetBundle(bundle_name)
+
+    print bundle.name
+    for key, value in bundle.iteritems():

[noelallen1, 2012/10/29 23:11:30]

Shouldn't these be sorted somehow?

[binji, 2012/10/29 23:51:18]

Done.

+      if key == manifest_util.ARCHIVES_KEY:
+        archive = bundle.GetHostOSArchive()
+        print '  Archive:'
+        if archive:
+          for archive_key, archive_value in archive.iteritems():

[noelallen1, 2012/10/29 23:11:30]

You print all archives if one is found for this host, but just print no archive
if there isn't one for this host.   Would printing all available archives and
then an error if no match make more sense?

[binji, 2012/10/29 23:51:18]

That's not quite right. I print all members of the host archive, or an error. I
think this is reasonable -- you can only install the HostOS archive. If there is
a bundle available only for another host os, do you really need info about it?

+            print '    %s: %s' % (archive_key, archive_value)
+        else:
+          print '    No archives for this host.'
+      elif key not in (manifest_util.ARCHIVES_KEY, manifest_util.NAME_KEY):
+        print '  %s: %s' % (key, value)
+    print