Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3069)

Unified Diff: base/files/important_file_writer_unittest.cc

Issue 11227026: Move ImportantFileWriter to base/. It now has two consumers, base/prefs and chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Win build Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/important_file_writer_unittest.cc
diff --git a/chrome/common/important_file_writer_unittest.cc b/base/files/important_file_writer_unittest.cc
similarity index 84%
rename from chrome/common/important_file_writer_unittest.cc
rename to base/files/important_file_writer_unittest.cc
index 35b2b44bc1be2b69cd43722303e0cc0ac6de3fe1..b4e8f0ff6793502c248714f9379cc79011547cd3 100644
--- a/chrome/common/important_file_writer_unittest.cc
+++ b/base/files/important_file_writer_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/important_file_writer.h"
+#include "base/files/important_file_writer.h"
#include "base/compiler_specific.h"
#include "base/file_path.h"
@@ -14,6 +14,8 @@
#include "base/time.h"
#include "testing/gtest/include/gtest/gtest.h"
+namespace base {
+
namespace {
std::string GetFileContent(const FilePath& path) {
@@ -58,7 +60,7 @@ class ImportantFileWriterTest : public testing::Test {
TEST_F(ImportantFileWriterTest, Basic) {
ImportantFileWriter writer(file_,
- base::MessageLoopProxy::current());
+ MessageLoopProxy::current());
EXPECT_FALSE(file_util::PathExists(writer.path()));
writer.WriteNow("foo");
loop_.RunAllPending();
@@ -69,8 +71,8 @@ TEST_F(ImportantFileWriterTest, Basic) {
TEST_F(ImportantFileWriterTest, ScheduleWrite) {
ImportantFileWriter writer(file_,
- base::MessageLoopProxy::current());
- writer.set_commit_interval(base::TimeDelta::FromMilliseconds(25));
+ MessageLoopProxy::current());
+ writer.set_commit_interval(TimeDelta::FromMilliseconds(25));
EXPECT_FALSE(writer.HasPendingWrite());
DataSerializer serializer("foo");
writer.ScheduleWrite(&serializer);
@@ -78,7 +80,7 @@ TEST_F(ImportantFileWriterTest, ScheduleWrite) {
MessageLoop::current()->PostDelayedTask(
FROM_HERE,
MessageLoop::QuitClosure(),
- base::TimeDelta::FromMilliseconds(100));
+ TimeDelta::FromMilliseconds(100));
MessageLoop::current()->Run();
EXPECT_FALSE(writer.HasPendingWrite());
ASSERT_TRUE(file_util::PathExists(writer.path()));
@@ -87,7 +89,7 @@ TEST_F(ImportantFileWriterTest, ScheduleWrite) {
TEST_F(ImportantFileWriterTest, DoScheduledWrite) {
ImportantFileWriter writer(file_,
- base::MessageLoopProxy::current());
+ MessageLoopProxy::current());
EXPECT_FALSE(writer.HasPendingWrite());
DataSerializer serializer("foo");
writer.ScheduleWrite(&serializer);
@@ -96,7 +98,7 @@ TEST_F(ImportantFileWriterTest, DoScheduledWrite) {
MessageLoop::current()->PostDelayedTask(
FROM_HERE,
MessageLoop::QuitClosure(),
- base::TimeDelta::FromMilliseconds(100));
+ TimeDelta::FromMilliseconds(100));
MessageLoop::current()->Run();
EXPECT_FALSE(writer.HasPendingWrite());
ASSERT_TRUE(file_util::PathExists(writer.path()));
@@ -106,8 +108,8 @@ TEST_F(ImportantFileWriterTest, DoScheduledWrite) {
// Flaky - http://crbug.com/109292
TEST_F(ImportantFileWriterTest, DISABLED_BatchingWrites) {
ImportantFileWriter writer(file_,
- base::MessageLoopProxy::current());
- writer.set_commit_interval(base::TimeDelta::FromMilliseconds(25));
+ MessageLoopProxy::current());
+ writer.set_commit_interval(TimeDelta::FromMilliseconds(25));
DataSerializer foo("foo"), bar("bar"), baz("baz");
writer.ScheduleWrite(&foo);
writer.ScheduleWrite(&bar);
@@ -115,8 +117,10 @@ TEST_F(ImportantFileWriterTest, DISABLED_BatchingWrites) {
MessageLoop::current()->PostDelayedTask(
FROM_HERE,
MessageLoop::QuitClosure(),
- base::TimeDelta::FromMilliseconds(100));
+ TimeDelta::FromMilliseconds(100));
MessageLoop::current()->Run();
ASSERT_TRUE(file_util::PathExists(writer.path()));
EXPECT_EQ("baz", GetFileContent(writer.path()));
}
+
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698