Move ImportantFileWriter to base/. It now has two consumers, base/prefs and chrome/.

base/files/important_file_writer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/common/important_file_writer.h"
+#include "base/files/important_file_writer.h"
 
 #include <stdio.h>
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
 #include "base/metrics/histogram.h"
 #include "base/string_number_conversions.h"
 #include "base/threading/thread.h"
 #include "base/time.h"
 
-using base::TimeDelta;
-
 namespace {
 
 const int kDefaultCommitIntervalMs = 10000;
 
 enum TempFileFailure {
   FAILED_CREATING,
   FAILED_OPENING,
   FAILED_CLOSING,
   FAILED_WRITING,
   FAILED_RENAMING,
@@ skipping 48 matching lines @@
 
   if (!file_util::ReplaceFile(tmp_file_path, path)) {
     LogFailure(path, FAILED_RENAMING, "could not rename temporary file");
     file_util::Delete(tmp_file_path, false);
     return;
   }
 }
 
 }  // namespace
 
+namespace base {

[brettw, 2012/10/24 03:30:54]

I usually put this around the whole thing (including the anon namespace) so you
don't have to prefix stuff w/ "base::" in there.

[Jói, 2012/10/24 10:19:17]

I did that as well, in patch set 4, doing it differently was an attempt to fix a
really weird compile error on Windows.  It still pops up at line 154 instead,
see
http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/73326/...

I'm putting the [ namespace base ] bit around the whole thing again, will figure
out the compiler confusion and then check in.

+
 ImportantFileWriter::ImportantFileWriter(
-    const FilePath& path, base::MessageLoopProxy* file_message_loop_proxy)
+    const FilePath& path, MessageLoopProxy* file_message_loop_proxy)
         : path_(path),
           file_message_loop_proxy_(file_message_loop_proxy),
           serializer_(NULL),
           commit_interval_(TimeDelta::FromMilliseconds(
               kDefaultCommitIntervalMs)) {
   DCHECK(CalledOnValidThread());
   DCHECK(file_message_loop_proxy_.get());
 }
 
 ImportantFileWriter::~ImportantFileWriter() {
@@ skipping 12 matching lines @@
   DCHECK(CalledOnValidThread());
   if (data.length() > static_cast<size_t>(kint32max)) {
     NOTREACHED();
     return;
   }
 
   if (HasPendingWrite())
     timer_.Stop();
 
   if (!file_message_loop_proxy_->PostTask(
-      FROM_HERE, base::Bind(&WriteToDiskTask, path_, data))) {
+      FROM_HERE, Bind(&WriteToDiskTask, path_, data))) {
     // Posting the task to background message loop is not expected
     // to fail, but if it does, avoid losing data and just hit the disk
     // on the current thread.
     NOTREACHED();
 
     WriteToDiskTask(path_, data);
   }
 }
 
 void ImportantFileWriter::ScheduleWrite(DataSerializer* serializer) {
@@ skipping 12 matching lines @@
   DCHECK(serializer_);
   std::string data;
   if (serializer_->SerializeData(&data)) {
     WriteNow(data);
   } else {
     DLOG(WARNING) << "failed to serialize data to be saved in "
                   << path_.value();
   }
   serializer_ = NULL;
 }
+
+}  // namespace base