Issue 1121003: Pass license-checker script for base/third_party/*.

Issue 1121003: Pass license-checker script for base/third_party/*. (Closed)

Created:
10 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
wtc, agl, M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org, brettw+cc_chromium.org, stuartmorgan, Timur Iskhodzhanov, Alexander Potapenko

Visibility:
Public.

Description

Pass license-checker script for base/third_party/*. License checker change: Since most projects have a LICENSE file, look for that by default. Since as far as I can tell NSS and NSPR are both just MPL tri-license without a per project copyright, I think I will amend the license-checker to source those licenses separately. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42016

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+193 lines, -16 lines)			Patch
A	base/third_party/dmg_fp/LICENSE	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	base/third_party/dmg_fp/README.chromium	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A	base/third_party/icu/LICENSE	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A +	base/third_party/icu/README.chromium	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/third_party/nspr/README.chromium	View	1 chunk	+3 lines, -2 lines	1 comment	Download
M	base/third_party/nss/README.chromium	View	1 chunk	+3 lines, -2 lines	1 comment	Download
A	base/third_party/purify/LICENSE	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	base/third_party/purify/README.chromium	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	base/third_party/symbolize/LICENSE	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	base/third_party/symbolize/README.chromium	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	base/third_party/valgrind/LICENSE	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A +	base/third_party/valgrind/README.chromium	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	base/third_party/xdg_mime/LICENSE	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	base/third_party/xdg_mime/README.chromium	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	base/third_party/xdg_user_dirs/LICENSE	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	base/third_party/xdg_user_dirs/README.chromium	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/licenses.py	View	2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 9 months ago (2010-03-18 22:39:45 UTC) #3

Evan, I have some suggested changes for NSPR and NSS below.

http://codereview.chromium.org/1121003/diff/1/6
File base/third_party/nspr/README.chromium (right):

http://codereview.chromium.org/1121003/diff/1/6#newcode3
base/third_party/nspr/README.chromium:3: License: MPL tri-license
Please call it MPL/GPL/LGPL tri-license.

For the LICENSE file, you can use the license header at
the top of
http://mxr.mozilla.org/nspr/source/nsprpub/pr/include/prtime.h?raw=1

(without the emacs mode line).

http://codereview.chromium.org/1121003/diff/1/7
File base/third_party/nss/README.chromium (right):

http://codereview.chromium.org/1121003/diff/1/7#newcode3
base/third_party/nss/README.chromium:3: License: MPL tri-license
Please call it MPL/GPL/LGPL tri-license.

For the LICENSE file, you can use the license header at the
top of
http://mxr.mozilla.org/security/source/security/nss/lib/util/secport.h?raw=1

Expand Messages | Collapse Messages