Automatic searching for vcvars32.bat and report if missing.

Automatic searching for vcvars.bat and report an error if the file cannot be found.

This is needed if you do not have VS in your PATH on purpose and makes life easy if you do not have it there by accident.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17854

[SkyLined, 2009-06-05 21:34:15]

Added script to automatically find vcvars32.bat in default location on x86 and
x64 systems as well as try to find it through PATH variable. Reports an error if
it fails to find the script and aborts. Aborts if the script fails and returns
errorlevel >=1 as well.

[M-A Ruel, 2009-06-06 00:57:02]

I don't mind, you can commit that if that works.

http://codereview.chromium.org/112098/diff/1/2
File chrome-update.bat (right):

http://codereview.chromium.org/112098/diff/1/2#newcode21
Line 21: IF EXIST "%~$PATH:1" (
I don't even understand what that does.

Frankly, I think this is overkill. If you don't have the default setup, you
should just have vcvars32.bat in the path.

[SkyLined, 2009-06-08 09:11:15]

I added documentation to briefly explain the use of "%~$PATH:1" and refer to
full documentation.

I can see that it is overkill if your setup is default but if you do not have a
default setup on purpose this is a must have (there is no work around afaik).

Also, if you do not have a default setup by accident, especially because you're
new to Chromium, a good error message explaining the problem is much more
helpful than the script failing without an obvious reason.

[SkyLined, 2009-06-08 09:13:44]

Let me know if you agree that this is useful or not.

[M-A Ruel, 2009-06-08 13:32:36]

lgtm