Avoiding IO completion callback during the closing

net/base/file_stream_unittest.cc

 // Copyright (c) 2008 The Chromium Authors. All rights reserved.  Use of this
 // source code is governed by a BSD-style license that can be found in the
 // LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/platform_file.h"
 #include "net/base/file_stream.h"
 #include "net/base/net_errors.h"
 #include "net/base/test_completion_callback.h"
@@ skipping 166 matching lines @@
   EXPECT_EQ(net::OK, rv);
 
   int64 total_bytes_avail = stream.Available();
   EXPECT_EQ(file_size, total_bytes_avail);
 
   TestCompletionCallback callback;
 
   char buf[4];
   rv = stream.Read(buf, arraysize(buf), &callback);
   stream.Close();
-  if (rv == net::ERR_IO_PENDING)
-    rv = callback.WaitForResult();
-  ASSERT_LE(0, rv);
-  EXPECT_EQ(std::string(kTestData, rv), std::string(buf, rv));
+  if (rv < 0) {
+    EXPECT_EQ(net::ERR_IO_PENDING, rv);
+    // The callback should not be called if the request is cancelled.
+    MessageLoop::current()->RunAllPending();
+    EXPECT_FALSE(callback.have_result());
+  } else {
+    EXPECT_EQ(std::string(kTestData, rv), std::string(buf, rv));
+  }
 }
 
 TEST_F(FileStreamTest, BasicRead_FromOffset) {
   int64 file_size;
   bool ok = file_util::GetFileSize(temp_file_path(), &file_size);
   EXPECT_TRUE(ok);
 
   net::FileStream stream;
   int flags = base::PLATFORM_FILE_OPEN |
               base::PLATFORM_FILE_READ;
@@ skipping 152 matching lines @@
   EXPECT_TRUE(ok);
   EXPECT_EQ(0, file_size);
 
   TestCompletionCallback callback;
   int total_bytes_written = 0;
 
   rv = stream.Write(kTestData + total_bytes_written,
                     kTestDataSize - total_bytes_written,
                     &callback);
   stream.Close();
-  if (rv == net::ERR_IO_PENDING)
-    rv = callback.WaitForResult();
-  ASSERT_LT(0, rv);
-  ok = file_util::GetFileSize(temp_file_path(), &file_size);
-  EXPECT_TRUE(ok);
-  EXPECT_EQ(file_size, rv);
+  if (rv < 0) {
+    EXPECT_EQ(net::ERR_IO_PENDING, rv);
+    // The callback should not be called if the request is cancelled.
+    MessageLoop::current()->RunAllPending();
+    EXPECT_FALSE(callback.have_result());
+  } else {
+    ok = file_util::GetFileSize(temp_file_path(), &file_size);
+    EXPECT_TRUE(ok);
+    EXPECT_EQ(file_size, rv);
+  }
 }
 
 TEST_F(FileStreamTest, BasicWrite_FromOffset) {
   net::FileStream stream;
   int flags = base::PLATFORM_FILE_OPEN |
               base::PLATFORM_FILE_WRITE;
   int rv = stream.Open(temp_file_path(), flags);
   EXPECT_EQ(net::OK, rv);
 
   int64 file_size;
@@ skipping 497 matching lines @@
   write_stream.Close();
 
   // Read in the contents and make sure we get back what we expected.
   std::string read_contents;
   file_util::ReadFileToString(temp_file_path(), &read_contents);
 
   EXPECT_EQ("01230123", read_contents);
 }
 
 }  // namespace