Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 112090: Avoiding IO completion callback during the closing (Closed)

Created:
11 years, 6 months ago by huanr
Modified:
9 years ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Avoiding IO completion callback during the closing of FileStream. BUG=8942 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17560

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M net/base/file_stream_posix.cc View 3 chunks +10 lines, -1 line 0 comments Download
M net/base/file_stream_unittest.cc View 3 2 chunks +18 lines, -10 lines 0 comments Download
M net/base/file_stream_win.cc View 1 3 chunks +8 lines, -1 line 1 comment Download
M net/base/test_completion_callback.h View 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
huanr
11 years, 6 months ago (2009-06-03 00:41:20 UTC) #1
rvargas (doing something else)
We should change FileStreamTest.AsyncRead_EarlyClose to match the new behavior. http://codereview.chromium.org/112090/diff/1/2 File net/base/file_stream_win.cc (right): http://codereview.chromium.org/112090/diff/1/2#newcode99 Line ...
11 years, 6 months ago (2009-06-03 01:20:46 UTC) #2
willchan no longer on Chromium
Do you need to update file_stream_posix.cc as well? On 2009/06/03 01:20:46, rvargas wrote: > We ...
11 years, 6 months ago (2009-06-03 01:37:00 UTC) #3
huanr
Updated based on comments from rvargas. Re: file_stream_posix.cc. Long term wise we need to do ...
11 years, 6 months ago (2009-06-03 03:30:54 UTC) #4
rvargas (doing something else)
http://codereview.chromium.org/112090/diff/2003/2005 File net/base/file_stream_unittest.cc (right): http://codereview.chromium.org/112090/diff/2003/2005#newcode188 Line 188: EXPECT_EQ(net::ERR_IO_PENDING, rv); Could you actually verify that the ...
11 years, 6 months ago (2009-06-03 17:36:46 UTC) #5
huanr
Good suggestion. Updated. On 2009/06/03 17:36:46, rvargas wrote: > http://codereview.chromium.org/112090/diff/2003/2005 > File net/base/file_stream_unittest.cc (right): > ...
11 years, 6 months ago (2009-06-03 20:26:30 UTC) #6
rvargas (doing something else)
LGTM.
11 years, 6 months ago (2009-06-03 21:05:55 UTC) #7
huanr
I have modified file_stream_posix.cc so the test could pass on all platforms. Will, can you ...
11 years, 6 months ago (2009-06-03 22:45:31 UTC) #8
willchan no longer on Chromium
Only had small minor comments. LGTM. Go ahead and land it. http://codereview.chromium.org/112090/diff/3011/3013 File net/base/file_stream_unittest.cc (right): ...
11 years, 6 months ago (2009-06-03 22:55:45 UTC) #9
brettw
11 years, 6 months ago (2009-06-03 23:43:04 UTC) #10
Drive by

http://codereview.chromium.org/112090/diff/3021/3022
File net/base/file_stream_win.cc (right):

http://codereview.chromium.org/112090/diff/3021/3022#newcode98
Line 98: if (is_closing_) {
Can you add a comment why this is here and what bad case we're trying to avoid?
Don't forget the Posix one too.

Powered by Google App Engine
This is Rietveld 408576698