Issue 112088: Successor to http://codereview.chromium.org/115748...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112088: Successor to http://codereview.chromium.org/115748... (Closed)

Created:
11 years, 6 months ago by pmarks

Modified:
9 years, 7 months ago

Reviewers:
brettw, eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Successor to http://codereview.chromium.org/115748 This change pulls in the new googleurl, which contains the ability to parse partial IPv6 literals. Add a test for chromium's SegmentURL, to verify that it's working. BUG=none TEST=Ran "unit_tests" in Debug and Release mode.

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/net/url_fixer_upper_unittest.cc	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pmarks

I don't have commit access to Chromium, so one of you will need to commit ...

11 years, 6 months ago (2009-06-03 23:46:55 UTC) #1

Committed as r17598

Expand Messages | Collapse Messages