Fix determining of JS lower stack bottom used in profiler's JS stack tracer to work with Chromium.

src/top.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 47 matching lines @@
   // unify them later.
   Object* scheduled_exception_;
   bool external_caught_exception_;
   v8::TryCatch* try_catch_handler_;
   SaveContext* save_context_;
   v8::TryCatch* catcher_;
 
   // Stack.
   Address c_entry_fp_;  // the frame pointer of the top c entry frame
   Address handler_;   // try-blocks are chained through the stack
+#ifdef ENABLE_LOGGING_AND_PROFILING
+  Address js_entry_sp_;  // the stack pointer of the bottom js entry frame
+#endif
   bool stack_is_cooked_;
   inline bool stack_is_cooked() { return stack_is_cooked_; }
   inline void set_stack_is_cooked(bool value) { stack_is_cooked_ = value; }
 
   // Generated code scratch locations.
   int32_t formal_count_;
 
   // Call back function to report unsafe JS accesses.
   v8::FailedAccessCheckCallback failed_access_check_callback_;
 };
 
+#ifdef ENABLE_LOGGING_AND_PROFILING
+#define JS_ENTRY_SP_ADDRESS(C) C(js_entry_sp_address)
+#else
+#define JS_ENTRY_SP_ADDRESS(C)
+#endif
+
 #define TOP_ADDRESS_LIST(C) \

[Søren Thygesen Gjesse, 2009/06/02 09:00:25]

How about making two lists TOP_ADDRESS_LIST_ALWAYS and
TOP_ADDRESS_LIST_PROFILING? See builtinsh.h and runtime.h where there is a
separate list for debugger related stuff (in runtime.h there is two _ALWAYS
lists due to Visual C++ choking on long macros).

[Mikhail Naganov, 2009/06/02 09:32:32]

Good idea. Done.

   C(handler_address)                   \
   C(c_entry_fp_address)                \
+  JS_ENTRY_SP_ADDRESS(C)               \
   C(context_address)                   \
   C(pending_exception_address)         \
   C(external_caught_exception_address)
 
 class Top {
  public:
   enum AddressId {
 #define C(name) k_##name,
     TOP_ADDRESS_LIST(C)
 #undef C
@@ skipping 80 matching lines @@
   static Address c_entry_fp(ThreadLocalTop* thread) {
     return thread->c_entry_fp_;
   }
   static Address handler(ThreadLocalTop* thread) { return thread->handler_; }
 
   static inline Address* c_entry_fp_address() {
     return &thread_local_.c_entry_fp_;
   }
   static inline Address* handler_address() { return &thread_local_.handler_; }
 
+#ifdef ENABLE_LOGGING_AND_PROFILING
+  // Bottom JS entry (see StackTracer::Trace in log.cc).
+  static Address js_entry_sp(ThreadLocalTop* thread) {
+    return thread->js_entry_sp_;
+  }
+  static inline Address* js_entry_sp_address() {
+    return &thread_local_.js_entry_sp_;
+  }
+#endif
+
   // Generated code scratch locations.
   static void* formal_count_address() { return &thread_local_.formal_count_; }
 
   static void MarkCompactPrologue(bool is_compacting);
   static void MarkCompactEpilogue(bool is_compacting);
   static void MarkCompactPrologue(bool is_compacting,
                                   char* archived_thread_data);
   static void MarkCompactEpilogue(bool is_compacting,
                                   char* archived_thread_data);
   static void PrintCurrentStackTrace(FILE* out);
@@ skipping 182 matching lines @@
 
 class ExecutionAccess BASE_EMBEDDED {
  public:
   ExecutionAccess();
   ~ExecutionAccess();
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_TOP_H_