Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 112068: chrome.gyp fixes to preserve various build behaviors... (Closed)

Created:
11 years, 7 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

chrome.gyp fixes to preserve various build behaviors and clean up some things: * Make <(grit_out_dir) a top-level variable, used by multiple targets. * Add precompiled.{cc,h} to various targets: common and plugin. * Add precompiled_wtl.{cc,h} to various targets: renderer, unit_tests, and url_fetch_test. * Add browser/net/test_url_fetcher_factory.cc to unit_tests. * Add dependencies on net_resources and webkit_resources to unit_tests and interactive_ui_tests. * Add a dependency on test_support_common to page_cycler_tests. * Add a dependency on net to url_fetch_test. * Pull in all of the installer/installer.gyp targets. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M chrome/chrome.gyp View 15 chunks +52 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
11 years, 7 months ago (2009-05-28 23:40:47 UTC) #1
bradn
11 years, 7 months ago (2009-05-28 23:43:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698