Implement Clear Browser Data for Mac as an app modal dialog. Uses the profile...

Implement Clear Browser Data for Mac as an app modal dialog. Uses the profile of the given window or the default profile if run with no windows open. Add a setter to the throbber so it can be used in a nib file.
BUG=none
TEST=clear browser functionality (note that clearing passwords doesn't work) and checkbox persistance.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17186

[TVL, 2009-05-28 13:34:39]

lgtm

you've got comments about support for tests, are there tests that should be
included/enabled in this cl?

http://codereview.chromium.org/112065/diff/2002/2006
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/112065/diff/2002/2006#newcode313
Line 313: [controller runModalDialog];
does this mean that if the prefs or about box is in the front, it will clear the
default profile instead of the one with the window on screen (that just happens
not to be in the front)?

http://codereview.chromium.org/112065/diff/2002/2008
File chrome/browser/cocoa/browser_window_cocoa.mm (right):

http://codereview.chromium.org/112065/diff/2002/2008#newcode9
Line 9: #include "chrome/browser/cocoa/browser_window_cocoa.h"
#import also?

http://codereview.chromium.org/112065/diff/2002/2010
File chrome/browser/cocoa/clear_browsing_data_controller.h (right):

http://codereview.chromium.org/112065/diff/2002/2010#newcode61
Line 61: @property BOOL isClearing;
nonatomic on these?

[pink (ping after 24hrs), 2009-05-28 14:58:09]

Forgot about the tests, I'll look into that when I get home. If nothing I'll
file a bug for unit tests since it will probably take some re-factoring to make
things testable outside of a modal dialog, and I'll do that in a followup CL.

http://codereview.chromium.org/112065/diff/2002/2006
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/112065/diff/2002/2006#newcode313
Line 313: [controller runModalDialog];
On 2009/05/28 13:34:39, TVL wrote:
> does this mean that if the prefs or about box is in the front, it will clear
the
> default profile instead of the one with the window on screen (that just
happens
> not to be in the front)?

A good question, and one that's going to take some UI thought. Right now, I
don't think we can have anything *but* the default profile (even in incognito
mode it still uses and clears the default profile). App mode won't have this
menu item, and will be in a separate process.

[pink (ping after 24hrs), 2009-05-29 12:56:38]

I made some small changes for showing a spinner while it was working, please
re-review.

There are no ui tests, so there's nothing to accompany. I'll file a bug for unit
tests.

[TVL, 2009-05-29 13:05:19]

lgtm w/ the one addition

http://codereview.chromium.org/112065/diff/2014/1020
File chrome/browser/cocoa/throbber_view.mm (right):

http://codereview.chromium.org/112065/diff/2014/1020#newcode45
Line 45: // TODO(pinkerton): The invalidation of the view to trigger re-draw
causes
this should also move into the setImage call with some tweaks:
  stop timer when clearning animationFrame_
  numFrames_ > 1, create timer

[pink (ping after 24hrs), 2009-05-29 13:19:11]

http://codereview.chromium.org/112065/diff/2014/1020
File chrome/browser/cocoa/throbber_view.mm (right):

http://codereview.chromium.org/112065/diff/2014/1020#newcode45
Line 45: // TODO(pinkerton): The invalidation of the view to trigger re-draw
causes
On 2009/05/29 13:05:19, TVL wrote:
> this should also move into the setImage call with some tweaks:
>   stop timer when clearning animationFrame_
>   numFrames_ > 1, create timer 

Done.