Issue 112064: Linux: call xdg-open on downloaded files to open them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112064: Linux: call xdg-open on downloaded files to open them. (Closed)

Created:
11 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: call xdg-open on downloaded files to open them. BUG=12299 TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17106

Patch Set 1 #

Patch Set 2 : fix typos #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -36 lines)			Patch
M	app/win_util.h	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	app/win_util.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/download/download_file.cc	View	1	1 chunk	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/download/download_shelf.cc	View		3 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/gtk/download_item_gtk.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/download_item_gtk.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/common/platform_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/platform_util_linux.cc	View		2 chunks	+17 lines, -5 lines	0 comments	Download
M	chrome/common/platform_util_mac.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/platform_util_win.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/win_safe_util.cc	View		3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages