Issue 112057: Backport r16212 and r16695 from the trunk to the 172...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112057: Backport r16212 and r16695 from the trunk to the 172... (Closed)

Created:
11 years, 7 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Mark Larson, eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/

Visibility:
Public.

Description

Backport r16212 and r16695 from the trunk to the 172 branch. AI_ADDRCONFIG is not necessary on Windows because its behavior is ON by default. Using AI_ADDRCONFIG can actually be harmful, as it causes getaddrinfo to fail to resolve "localhost" when the computer is not connected to a network. R=eroman,mal http://crbug.com/5234 TEST=See bug 5234 for instructions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16817

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	net/base/host_resolver.cc	View		1 chunk	+26 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Larson

11 years, 7 months ago (2009-05-22 23:28:30 UTC) #2

LGTM

Awesome. This is the kind of simple patch that makes me happy.

Expand Messages | Collapse Messages