Issue 112055: Roll DEPS and fix build bustage. Propagate rename of policyBaseURL -> firstP...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112055: Roll DEPS and fix build bustage. Propagate rename of policyBaseURL -> firstP... (Closed)

Created:
11 years, 7 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Roll DEPS and fix build bustage. Propagate rename of policyBaseURL -> firstPartyForCookies a bit further. TBR=darin TEST=It complies! BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16804

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -18 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/api/public/WebURLRequest.h	View		1 chunk	+2 lines, -2 lines	2 comments	Download
M	webkit/api/src/ChromiumBridge.cpp	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	webkit/glue/resource_handle_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webframeloaderclient_impl.cc	View	1 2	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM http://codereview.chromium.org/112055/diff/1011/1015 File webkit/api/public/WebURLRequest.h (right): http://codereview.chromium.org/112055/diff/1011/1015#newcode79 Line 79: WEBKIT_API WebURL firstPartyForCookies() const = 0; thanks ...

11 years, 7 months ago (2009-05-22 23:20:03 UTC) #2

abarth-chromium

http://codereview.chromium.org/112055/diff/1011/1015 File webkit/api/public/WebURLRequest.h (right): http://codereview.chromium.org/112055/diff/1011/1015#newcode79 Line 79: WEBKIT_API WebURL firstPartyForCookies() const = 0; On 2009/05/22 ...

11 years, 7 months ago (2009-05-22 23:25:47 UTC) #3

darin (slow to review)

11 years, 7 months ago (2009-05-23 00:03:38 UTC) #4

no worries.  there is no implementation.  in fact, this header file cannot be
compiled yet!  i am working on hooking up this file soon.  the webkit API has a
bunch of as yet unused headers (see the #error at the top of the file).

Expand Messages | Collapse Messages