Issue 112042: Prevent an extra copy of data types that get passed into IPC messages when...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112042: Prevent an extra copy of data types that get passed into IPC messages when... (Closed)

Created:
11 years, 7 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Prevent an extra copy of data types that get passed into IPC messages when sending them. This makes it so that types sendable via IPC no longer need copy constructors. BUG=12296 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16497

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -75 lines)			Patch
M	base/tuple.h	View		8 chunks	+29 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_unittest.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/common/ipc_fuzzing_tests.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/ipc_message_macros.h	View		33 chunks	+62 lines, -61 lines	0 comments	Download
M	chrome/common/ipc_message_utils.h	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/common/resource_dispatcher_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Matt Perry

11 years, 7 months ago (2009-05-20 17:41:46 UTC) #3

FYI, I had to fix a couple unit tests that were manually unpacking IPC message
arguments, since I changed 1-arg messages to use Tuple1.