Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 112035: Add method for getting global v8::Context (Closed)

Created:
11 years, 7 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Exposed method for finding global context by traversing context chain to API. Committed: http://code.google.com/p/v8/source/detail?r=2005

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -14 lines) Patch
M src/debug.cc View 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 2 3 4 5 4 chunks +114 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
11 years, 7 months ago (2009-05-19 11:56:57 UTC) #1
Søren Thygesen Gjesse
This is not the way to go, as the contexts exposed through the API are ...
11 years, 7 months ago (2009-05-19 12:08:46 UTC) #2
yurys
On 2009/05/19 12:08:46, Søren Gjesse wrote: > This is not the way to go, as ...
11 years, 7 months ago (2009-05-19 17:10:29 UTC) #3
Søren Thygesen Gjesse
LGTM! Thanks for fixing this (and finding the simpler and right solution) and for adding ...
11 years, 7 months ago (2009-05-20 07:24:02 UTC) #4
yurys
11 years, 7 months ago (2009-05-20 07:28:38 UTC) #5
http://codereview.chromium.org/112035/diff/2007/3014
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/112035/diff/2007/3014#newcode4175
Line 4175: // Sends conutinue command to the debugger.
On 2009/05/20 07:24:02, Søren Gjesse wrote:
> conutinue -> continue

Done.

Powered by Google App Engine
This is Rietveld 408576698