Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 112032: Promotes Add/RemoveObserver to MessageLoop for linux. Because... (Closed)

Created:
11 years, 7 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Promotes Add/RemoveObserver to MessageLoop for linux. Because message_loop.h now includes message_pump_glib.h I needed to update the dependencies of a couple of projects. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16317

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M base/base.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M base/message_loop.h View 1 2 chunks +14 lines, -1 line 0 comments Download
M base/message_loop.cc View 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
11 years, 7 months ago (2009-05-18 17:03:02 UTC) #1
Evan Martin
http://codereview.chromium.org/112032/diff/1/4 File base/message_loop.h (right): http://codereview.chromium.org/112032/diff/1/4#newcode26 Line 26: #include "base/message_pump_glib.h" I guess you probably only want ...
11 years, 7 months ago (2009-05-18 17:18:11 UTC) #2
sky
New snapshot uploaded. http://codereview.chromium.org/112032/diff/1/4 File base/message_loop.h (right): http://codereview.chromium.org/112032/diff/1/4#newcode26 Line 26: #include "base/message_pump_glib.h" On 2009/05/18 17:18:11, ...
11 years, 7 months ago (2009-05-18 17:53:54 UTC) #3
Evan Martin
11 years, 7 months ago (2009-05-18 18:19:45 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698