Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 112025: revert 12598 now that text-overflow:ellipsis has been fixed in WebKit. (Closed)

Created:
11 years, 7 months ago by jeremy
Modified:
9 years, 6 months ago
Reviewers:
xji
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

revert 12598 now that text-overflow:ellipsis has been fixed in WebKit. BUG=7697 TEST=Open RTL Chrome (--lang=he), load ynet.co.il, load mako.co.il, open new tab page. Observe that ellipsis is placed correctly at the end of the page titles for aforementioned sites and that the underline is under the whole title and not just under the ellipsis. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M chrome/browser/resources/new_tab.html View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jeremy
11 years, 7 months ago (2009-05-14 20:27:26 UTC) #1
xji
11 years, 7 months ago (2009-05-14 21:02:18 UTC) #2
On 2009/05/14 20:27:26, jeremy wrote:
> 

LGTM.

BTW, you also checked that the title displayed for "yet.co.il" is completed
(without "ynet" being truncated), right?

Thanks,
Xiaomei

Powered by Google App Engine
This is Rietveld 408576698