Fix the "ls -l" style date parser to correctly guess the year if it is not provided.

Fix the "ls -l" style date parser to correctly guess the year if it is not provided.

Also provide an infrastructure to mock the current time in the tests.

BUG=36293
TEST=net_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42447

[eroman, 2010-03-23 18:29:43]

lgtm

http://codereview.chromium.org/1120012/diff/1/13
File net/ftp/ftp_directory_listing_buffer.h (right):

http://codereview.chromium.org/1120012/diff/1/13#newcode24
net/ftp/ftp_directory_listing_buffer.h:24: FtpDirectoryListingBuffer(const
base::Time& current_time);
please mark as explicit. Also can you add a comment of what |current_time| is
for?

http://codereview.chromium.org/1120012/diff/1/19
File net/ftp/ftp_directory_listing_parser_netware.h (right):

http://codereview.chromium.org/1120012/diff/1/19#newcode18
net/ftp/ftp_directory_listing_parser_netware.h:18:
FtpDirectoryListingParserNetware(const base::Time& current_time);
explicit.

[Paweł Hajdan Jr., 2010-03-23 18:40:49]

All fixed, please take another look to see if the comments are clear.

[eroman, 2010-03-23 19:32:21]

LGTM

http://codereview.chromium.org/1120012/diff/6001/7012
File net/ftp/ftp_directory_listing_buffer.h (right):

http://codereview.chromium.org/1120012/diff/6001/7012#newcode24
net/ftp/ftp_directory_listing_buffer.h:24: // Constructor. When the current time
is needed, |current_time| will be used.
nit: I suggest being a bit more explicit on what |current_time| is used for,
say: "|current_time| is used to guess the year on partial date strings"