Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1120007: Disable backup connect jobs for all pools except TCPClientSocketPool (Closed)

Created:
10 years, 9 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable backup connect jobs for all pools except TCPClientSocketPool BUG=36629 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M net/socket/client_socket_pool_base.h View 3 chunks +7 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M net/socket/tcp_client_socket_pool.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
vandebo (ex-Chrome)
10 years, 9 months ago (2010-03-19 22:59:13 UTC) #1
Mike Belshe
lgtm
10 years, 9 months ago (2010-03-19 23:00:48 UTC) #2
willchan no longer on Chromium
10 years, 9 months ago (2010-03-19 23:01:33 UTC) #3
LGTM as an interim measure.

Powered by Google App Engine
This is Rietveld 408576698