chrome/test/automation/javascript_execution_controller.cc - Issue 1120006: detect preferences errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/automation/javascript_execution_controller.cc

Issue 1120006: detect preferences errors (Closed)

Patch Set: changes from review Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/automation/javascript_execution_controller.cc

diff --git a/chrome/test/automation/javascript_execution_controller.cc b/chrome/test/automation/javascript_execution_controller.cc

index 26d32d082a1d1a3def92a56d00083fa212d269fd..3cd0753c95af9e279eb7da503d82266f82ad2875 100644

--- a/chrome/test/automation/javascript_execution_controller.cc

+++ b/chrome/test/automation/javascript_execution_controller.cc

@@ -72,7 +72,7 @@ bool JavaScriptExecutionController::ParseJSON(const std::string& json,

scoped_ptr<Value>* result) {

JSONStringValueSerializer parse(json);

std::string parsing_error;

- scoped_ptr<Value> root_value(parse.Deserialize(&parsing_error));

+ scoped_ptr<Value> root_value(parse.Deserialize(NULL, &parsing_error));

if (!root_value.get()) {

if (parsing_error.length())