chrome/installer/util/google_chrome_distribution.cc - Issue 1120006: detect preferences errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 1120006: detect preferences errors (Closed)

Patch Set: changes from review Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/google_chrome_distribution.cc

diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc

index c7620483038cb7be8c2de432c4f444bdd2d84427..95b649bc394187d011216356e517a1fbe74fcfaa 100644

--- a/chrome/installer/util/google_chrome_distribution.cc

+++ b/chrome/installer/util/google_chrome_distribution.cc

@@ -192,7 +192,7 @@ bool GoogleChromeDistribution::ExtractUninstallMetricsFromFile(

JSONFileValueSerializer json_serializer(FilePath::FromWStringHack(file_path));

std::string json_error_string;

- scoped_ptr<Value> root(json_serializer.Deserialize(NULL));

+ scoped_ptr<Value> root(json_serializer.Deserialize(NULL, NULL));

if (!root.get())

return false;