chrome/browser/pref_service_uitest.cc - Issue 1120006: detect preferences errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/pref_service_uitest.cc

Issue 1120006: detect preferences errors (Closed)

Patch Set: changes from review Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/pref_service_uitest.cc

diff --git a/chrome/browser/pref_service_uitest.cc b/chrome/browser/pref_service_uitest.cc

index 79f00d3770a173bfc1895e76d21a9c0058ac201c..87dcb2c1c0272b1e07074a428f59f3be05dfbac9 100644

--- a/chrome/browser/pref_service_uitest.cc

+++ b/chrome/browser/pref_service_uitest.cc

@@ -86,7 +86,7 @@ TEST_F(PreferenceServiceTest, PreservedWindowPlacementIsLoaded) {

ASSERT_TRUE(file_util::PathExists(tmp_pref_file_));

JSONFileValueSerializer deserializer(tmp_pref_file_);

- scoped_ptr<Value> root(deserializer.Deserialize(NULL));

+ scoped_ptr<Value> root(deserializer.Deserialize(NULL, NULL));

ASSERT_TRUE(root.get());

ASSERT_TRUE(root->IsType(Value::TYPE_DICTIONARY));